Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-controls to beef up accessibility #69

Closed
TheAce74 opened this issue Feb 17, 2024 · 3 comments
Closed

aria-controls to beef up accessibility #69

TheAce74 opened this issue Feb 17, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@TheAce74
Copy link

I've been using this package for a while and I've got no complaints; it's awesome 🔥

Would it be possible to add a controls prop to the hamburgers? It would provide more context to screen readers about the actual item the hamburger is controlling.

I've been working around this with this hack:

  useEffect(() => {
    const menu = document.querySelector(".hamburger-react");
    menu.setAttribute("aria-controls", "primary-navigation");
  }, []);

If it is possible, can I be assigned to the task?

@cyntler
Copy link
Owner

cyntler commented Feb 27, 2024

@TheAce74 Yes! I assigned the task to you!

@cyntler cyntler added the enhancement New feature or request label Feb 27, 2024
@TheAce74
Copy link
Author

@cyntler Thank you, I'll start working on it as soon as I can

@TheAce74
Copy link
Author

TheAce74 commented Feb 28, 2024

@cyntler I just added this enhancement, please refer to #71 for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants