Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orb publishing does not work for contributor PRs #451

Open
jennifer-shehane opened this issue Jan 11, 2024 · 3 comments
Open

Orb publishing does not work for contributor PRs #451

jennifer-shehane opened this issue Jan 11, 2024 · 3 comments
Labels
type: bug 🐛 Something isn't working

Comments

@jennifer-shehane
Copy link
Member

Orb publishing doesn't work for contributor PRs since they don't have access to the CIRCLECI_TOKEN for example: https://app.circleci.com/pipelines/github/ramykl/circleci-orb/2/workflows/80a14831-88d2-49c3-9349-63efa630c614/jobs/10

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Oct 1, 2024

This restriction is a major disadvantage for the quality of Contributor PRs!

A regular PR runs orb-tools/lint which provides a preview of the published orb. The job is blocked for Contributor PRs until the PR is merged into master, which is really too late to be finding issues.

The whole set of checking tools described in https://github.com/CircleCI-Public/orb-tools-orb/ under Local Linting etc. also only works for owners of the Orb i.e. members of the Cypress.io organization in this case.

@MikeMcC399
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants