fix: 28638 parent absolute #29689
fix: 28638 parent absolute #29689
Conversation
|
|
Unit test -Delegate cloud is probably not related. |
cli/CHANGELOG.md
Outdated
| @@ -33,6 +34,7 @@ _Released 6/18/2024_ | |||
| - Fixed an issue where `inlineSourceMaps` was still being used when `sourceMaps` was provided in a users typescript config for typescript version 5. Fixes [#26203](https://github.com/cypress-io/cypress/issues/26203). | |||
| - When capture protocol script fails verification, an appropriate error is now displayed. Previously, an error regarding Test Replay archive location was shown. Addressed in [#29603](https://github.com/cypress-io/cypress/pull/29603). | |||
| - Fixed an issue where receiving HTTP responses with invalid headers raised an error. Now cypress removes the invalid headers and gives a warning in the console with debug mode on. Fixes [#28865](https://github.com/cypress-io/cypress/issues/28865). | |||
| - Fixed an issue where "isVisible" is incorrectly assessed for the absolutely positioned elements if the ancestor has overflow and static position [#29689](https://github.com/cypress-io/cypress/pull/29689). | |||
There was a problem hiding this comment.
Does this belong here?
There was a problem hiding this comment.
Yes. And it's required by pipeline. Of course position could be discussed but it's fix issue reported by user so probably should be in Bugfixes
| @@ -367,7 +367,7 @@ describe('src/cypress/dom/visibility', () => { | |||
| `) | |||
|
|
|||
| this.$elOutOfParentBoundsAbove = add(`\ | |||
| <div style='width: 100px; height: 100px; overflow: hidden; position: relative;'> | |||
| <div style='width: 100px; height: 100px; overflow: hidden; position: fixed;'> | |||
There was a problem hiding this comment.
Could you explain this change more fully?
There was a problem hiding this comment.
This is needed to firefox to behave like other browsers in this tests. Test check el out of bound and this not changed. And in browser it could be seen as same. But Firefox do not like combination of relative and absolute. Maybe in future it will behave same as other browsers. But for pipeline Firefox version this seems like simple walkaround.
There was a problem hiding this comment.
Alternatively test could stay not changed and { browser: '!firefox' } added to this test.
|
Now looks like pipeline fail on unrelated certificate. |
|
@senpl There are still failures here that need addressing. Please check the test files locally before committing, to ensure they pass. |
…/cypress into issue-28638-parentAbsolute
|
All tests passed. What else is needed ??? |
|
@senpl We'll need to spend some time reviewing the changes. |
|
We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925 |
jennifer-shehane
requested review from
mschile
and removed request for
jennifer-shehane
Fix for parent overflow and element position absolute detection
"isVisible" is incorrectly assessed for the absolutely positioned elements if the ancestor has overflow and static position #28638
Additional details
Some changes to detect of visibility as in other of my PR. Still without them this fix not work.
Steps to test
as described in 28638.
How has the user experience changed?
Element now should be clickable without force: true walkaround.
PR Tasks
cypress-documentation?type definitions?