Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Replace experimentalJustInTimeCompile flag with justInTimeCompile flag, make it true by default #30402

Open
wants to merge 15 commits into
base: release/14.0.0
Choose a base branch
from

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Oct 11, 2024

Additional details

This removes the component testing specific experimentalJustInTimeCompile configuration and replaces it with a justInTimeCompile which is true by default.

Additionally, the just in time compile logic will now only apply to webpack and no longer to vite (which was not working well anyway with how vite works)

Steps to test

How has the user experience changed?

PR Tasks

…g and make it default

BREAKING: Replace experimentalJustInTimeCompile flag with justInTimeCompile flag and make it default
Copy link

cypress bot commented Oct 11, 2024

cypress    Run #58080

Run Properties:  status check cancelled Cancelled #58080  •  git commit 039144bfed: Merge branch 'release/14.0.0' into experimentalJIT-default
Project cypress
Branch Review experimentalJIT-default
Run status status check cancelled Cancelled #58080
Run duration 31m 00s
Commit git commit 039144bfed: Merge branch 'release/14.0.0' into experimentalJIT-default
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 17
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 1308
Tests that did not run due to a failure in a mocha hook  Skipped 31
Tests that passed  Passing 28654
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  42.3%
  Untested elements 201  
  Tested elements 151  
Accessibility  92.51%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 884  

Tests for review

Failed  src/navigation/SidebarNavigation.cy.tsx • 1 failed test • app-ct

View Output

Test Artifacts
SidebarNavigation > expands the bar when clicking the expand button Test Replay Screenshots
Failed  src/specs/generators/ExpandableFileChooser.cy.tsx • 1 failed test • app-ct

View Output

Test Artifacts
> filters the files by file name Test Replay
Failed  cypress/e2e/commands/actions/hover.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  cypress/e2e/cy/timeouts.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  cypress/e2e/util/blob.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts

The first 5 failed specs are shown, see all 180 specs in Cypress Cloud.

Flakiness  src/specs/generators/ExpandableFileChooser.cy.tsx • 1 flaky test • app-ct

View Output

Test Artifacts
> no results > does not show no results when there are files Test Replay Screenshots
Flakiness  src/components/promo/Promo.cy.tsx • 1 flaky test • app-ct

View Output

Test Artifacts
> records event on initial render Test Replay
Flakiness  cypress/e2e/e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay
Flakiness  cypress/e2e/commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
... > errors > throws when waiting for 2nd response to route Test Replay
Flakiness  cypress/e2e/commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/58080/overview/3f7dc237-2d86-46f0-95d6-7960977b9872?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/58080/overview/c36cabcf-3501-41d9-9168-8c1d2a6a7566?reviewViewBy=FLAKY&utm_source=github&utm_medium=failed&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

@jennifer-shehane jennifer-shehane self-assigned this Oct 22, 2024
@jennifer-shehane jennifer-shehane changed the title Replace experimentalJustInTimeCompile flag with justInTimeCompile flag, make it true by default breaking: Replace experimentalJustInTimeCompile flag with justInTimeCompile flag, make it true by default Oct 24, 2024
@jennifer-shehane
Copy link
Member Author

@AtofStryker Noticed this note and don't want to forget this: https://github.com/cypress-io/cypress/blob/experimentalJIT-default/packages/server/lib/modes/run.ts#L822

// TODO: this logic to skip updating the dev-server on cancel needs a system-test before the feature goes generally available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant