Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicative all-at-once concatenate with join operations #168

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Mar 15, 2024

Description

This PR removes a duplicative and all-at-once concatenate during CytoTable join operations. It was discovered while trying to replicate / confirm findings for #38 with SQ00014613.sqlite (which appears to no longer face direct challenges with data value translation but faces large memory resource consumption issues as a result of the removed block in this PR). After this is applied we should see performance benefits (as join concatenation will only take place once) and better opportunity to avoid memory resource constraint issues.

References #38
Likely effects discussion on recommendations in #163

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@d33bs
Copy link
Member Author

d33bs commented Mar 16, 2024

Thanks @kenibrewer ! Merging this in.

@d33bs d33bs merged commit 4f4b6da into cytomining:main Mar 16, 2024
7 checks passed
@d33bs d33bs deleted the avoid-all-at-once-joins branch March 16, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants