Remove duplicative all-at-once concatenate with join operations #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a duplicative and all-at-once concatenate during CytoTable join operations. It was discovered while trying to replicate / confirm findings for #38 with
SQ00014613.sqlite
(which appears to no longer face direct challenges with data value translation but faces large memory resource consumption issues as a result of the removed block in this PR). After this is applied we should see performance benefits (as join concatenation will only take place once) and better opportunity to avoid memory resource constraint issues.References #38
Likely effects discussion on recommendations in #163
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.