Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locate other performance bottlenecks, document, and add testing constraints #227

Open
gwaybio opened this issue Aug 19, 2022 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@gwaybio
Copy link
Member

gwaybio commented Aug 19, 2022

Discussed in #195 (comment)

Add Memory/Time Testing Constraints for .merge_single_cells() (or others! 🙂 ) (Something like pytest-memray or similar): automate targeted performance tests to ensure operations within this project are usable by others as appropriate. Maybe this one spot was an outlier, but if there are other performance-heavy functions we could expand there as well.

@jenna-tomkinson
Copy link
Member

@d33bs Is this issue resolved?

@d33bs
Copy link
Member

d33bs commented Jun 8, 2023

@jenna-tomkinson - thanks, this is not yet resolved. In order for this to be resolved, I think the following steps would be needed (at a minimum):

  • Capture expected "usual" time duration or memory amount for SingleCells.merge_single_cells to run.
  • Add pytest-memray (or similar) dependency for dev / testing requirements.
  • Add time duration or memory from above as a constraint for one or more SingleCells.merge_single_cells tests.
  • Validate that the tests are able to pass for local development, within devcontainers associated with this project, and also Github actions (possibly finding a way to bind these in a reasonable manner)
  • Document these new expectations where reasonable.

@d33bs d33bs moved this to Paused in SET Projects Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants