From 8eb384d0d827b25d63cb6fed28cafae40cedd147 Mon Sep 17 00:00:00 2001 From: Florian Hopfner Date: Thu, 3 Oct 2024 12:56:25 +0200 Subject: [PATCH] remove AzureAD dependency resolves #744 --- .github/workflows/dependencies.yml | 5 ----- build/vsts-prerequisites.ps1 | 2 +- build/vsts-validate-psscriptanalyzer.ps1 | 2 +- build/vsts-validate.ps1 | 2 +- d365fo.tools/d365fo.tools.psd1 | 1 - 5 files changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml index 1e6a0c66..ef06655b 100644 --- a/.github/workflows/dependencies.yml +++ b/.github/workflows/dependencies.yml @@ -14,11 +14,6 @@ jobs: uses: PowershellFrameworkCollective/psframework@32c18f13173be8cc6b6803c63c40b9d7ab5aec12 # version 1.0.12 - name: Azure.Storage uses: Azure/azure-powershell@v4.4.0-September2017 # unclear which commit/tag corresponds to https://www.powershellgallery.com/packages/Azure.Storage/4.4.0 - # AzureAd does not seem to have a public GitHub repository - # - name: AzureAd - # uses: - - name: PSNotification - uses: Splaxi/PSNotification@b344c3dfdb04db1a338f203d1a0c5ae72d67ae89 # version 0.5.3 - name: PSOAuthHelper uses: Splaxi/PSOAuthHelper@837a2da63bf76e86f339a4e43e38df5a3b82affe # version 0.3.0 - name: ImportExcel diff --git a/build/vsts-prerequisites.ps1 b/build/vsts-prerequisites.ps1 index 68dda50d..19149705 100644 --- a/build/vsts-prerequisites.ps1 +++ b/build/vsts-prerequisites.ps1 @@ -2,7 +2,7 @@ Write-Host "The user running is: $($env:UserName)" # $modules = @("PSFramework", "Az.Storage", "AzureAd", "PSNotification", "PSOAuthHelper", "PowerShellGet", "PackageManagement","ImportExcel","PSScriptAnalyzer") -$modules = @("PSFramework", "PSScriptAnalyzer", "Az.Storage", "AzureAd", "PSNotification", "PSOAuthHelper", "ImportExcel") +$modules = @("PSFramework", "PSScriptAnalyzer", "Az.Storage", "PSOAuthHelper", "ImportExcel") Install-Module "Pester" -MaximumVersion 4.99.99 -Force -Confirm:$false -Scope CurrentUser -AllowClobber -SkipPublisherCheck diff --git a/build/vsts-validate-psscriptanalyzer.ps1 b/build/vsts-validate-psscriptanalyzer.ps1 index 98892d91..d3ae8474 100644 --- a/build/vsts-validate-psscriptanalyzer.ps1 +++ b/build/vsts-validate-psscriptanalyzer.ps1 @@ -14,7 +14,7 @@ Write-Host "Working on the machine named: $($env:computername)" Write-Host "The user running is: $($env:UserName)" -$modules = @("PSFramework", "PSScriptAnalyzer", "Az.Storage", "AzureAd", "PSNotification", "PSOAuthHelper", "ImportExcel") +$modules = @("PSFramework", "PSScriptAnalyzer", "Az.Storage", "PSOAuthHelper", "ImportExcel") foreach ($item in $modules) { $module = Get-Module -Name $item -ErrorAction SilentlyContinue diff --git a/build/vsts-validate.ps1 b/build/vsts-validate.ps1 index e17d06b2..80a1f362 100644 --- a/build/vsts-validate.ps1 +++ b/build/vsts-validate.ps1 @@ -17,7 +17,7 @@ Write-Host "Working on the machine named: $($env:computername)" Write-Host "The user running is: $($env:UserName)" -$modules = @("PSFramework", "PSScriptAnalyzer", "Az.Storage", "AzureAd", "PSNotification", "PSOAuthHelper", "ImportExcel") +$modules = @("PSFramework", "PSScriptAnalyzer", "Az.Storage", "PSOAuthHelper", "ImportExcel") foreach ($item in $modules) { $module = Get-Module -Name $item -ErrorAction SilentlyContinue diff --git a/d365fo.tools/d365fo.tools.psd1 b/d365fo.tools/d365fo.tools.psd1 index 42054bbb..7acdeb3e 100644 --- a/d365fo.tools/d365fo.tools.psd1 +++ b/d365fo.tools/d365fo.tools.psd1 @@ -30,7 +30,6 @@ RequiredModules = @( @{ ModuleName = 'PSFramework'; ModuleVersion = '1.0.12' } , @{ ModuleName = 'Az.Storage'; ModuleVersion = '1.11.0' } - , @{ ModuleName = 'AzureAd'; ModuleVersion = '2.0.1.16' } , @{ ModuleName = 'PSOAuthHelper'; ModuleVersion = '0.3.0' } , @{ ModuleName = 'ImportExcel'; ModuleVersion = '7.1.0' } )