Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #120

Closed
Hellzevir opened this issue Feb 12, 2023 · 8 comments
Closed

French translation #120

Hellzevir opened this issue Feb 12, 2023 · 8 comments

Comments

@Hellzevir
Copy link
Contributor

Hello,

I have been using TLP since 2015, and discovered two years ago tlp-ui. I have just reinstalled it on my new system and I can see that for this great tool, that makes the use of tlp easier, French translation is still missing.

I would like to contribute and would be pleased to provide with a translation.

Thanks for your interest.

@d4nj1
Copy link
Owner

d4nj1 commented Feb 13, 2023

Thanks for your offerings. I just created #121 which will ease up the process once implemented.

@Hellzevir
Copy link
Contributor Author

Ok, thanks. So, like you suggested to my Italian pal, I'm going to start translating PO files into French.

@d4nj1
Copy link
Owner

d4nj1 commented Feb 14, 2023

Awesome! Thanks for the efforts.

@Hellzevir
Copy link
Contributor Author

Translation is finished! (based on 1.5.0-5). I'm just checking and correcting my work.
Once finished, should I upload the .mo and .po files in TLPUI/tlpui/lang/, or should I attach them here?
Thanks.

@d4nj1
Copy link
Owner

d4nj1 commented Mar 14, 2023

Hi,
ideally I would suggest you create /tlpui/lang/fr_FR/LC_MESSAGES folder with your translated .po files in it and then create a PR for it.
I would then generate the .mo files and add the necessary language related stuff so that you can select French in the UI.

Would that ok for you?

@Hellzevir
Copy link
Contributor Author

Hi, perfect! I'll upload my .po files as you propose, and then I'll leave the rest to you. ;-)

@Hellzevir
Copy link
Contributor Author

Hi! Done. Hope everything is fine.

d4nj1 added a commit that referenced this issue Aug 25, 2023
@d4nj1
Copy link
Owner

d4nj1 commented Aug 25, 2023

Hi,
I finally added French translation. This will be released once I finish adopting TLPUI to TLP 1.6.

Thanks and kind regards

@d4nj1 d4nj1 closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants