-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action fails with wails 2.3.1 on MacOS due to ditto error #11
Comments
Hiya, We found a bug in wails for macOS builds with a different name. https://github.com/dAppServer/wails-build-action/actions/runs/3885309312/jobs/6629024935 You can "fix" this using the same 'build-name' as defined in the wails app settings; linux and windows honour this so its a bug for @leaanthony macos:
runs-on: macos-latest
steps:
# Checkout code
- uses: actions/checkout@v3
with:
submodules: recursive
- uses: dAppServer/wails-build-action@v2
with:
build-name: cohort-wails
build-platform: darwin/universal
wails-build-webview2: "embed"
wails-version: "v2.3.1"
go-version: ^1.18
sign: "false" |
Interesting! Please open a ticket on the Wails repo 🙏 |
wailsapp/wails#2290 :) 🙏 |
Just to update people interested in this @gwynforthewyn is working on the fix atm, once Wails publishes a version with her fix, this issue will be resolved by increasing the wails version. |
Any updates on this? |
Any updates on this, I got this error when building macOS
|
Looks like the space in file name caused this error, but when I tried to remove the space, then got another error
|
Huh; I thought I had fixed this long ago. I can try dusting off my recollections of wails : ) |
Is it possible for you to take a look at it one more time? |
Just bumping this issue as I am also facing this issue at the moment. |
It seems this issue happens whenever the app name has a space. My app is named "MIDI Scout" and renaming to "MIDIScout" fixed the issue. |
I would recommend to just copy this action and include it into your own repo and apply some fixes yourself. - name: Build .app zip file
if: runner.os == 'macOS'
working-directory: ${{ inputs.app-working-directory }}
shell: bash
run: |
ditto -c -k ${{ inputs.app-working-directory }}/build/bin/${{inputs.build-name}}.app ${{ inputs.app-working-directory }}/build/bin/${{inputs.build-name}}.app.zip This is due to the fact that working-directory: This issue is seen across many different places: and also the last few release steps are missing that as well: # Upload build assets
- uses: actions/upload-artifact@v3
if: inputs.package == 'true'
with:
name: Wails Build ${{runner.os}} ${{inputs.build-name}}
path: |
*/bin/
*\bin\*
- name: Release
uses: softprops/action-gh-release@v1
if: inputs.package == 'true' && startsWith(github.ref, 'refs/tags/')
with:
files: |
*/bin/* should have |
Still unsolved. |
When running this action on GitHub with the
darwin/universal
platform and wails version 2.3.1, the run fails on the ditto step with the following error:The text was updated successfully, but these errors were encountered: