Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work on Imgur gifv links? #238

Open
rruester opened this issue Jun 22, 2016 · 2 comments
Open

Doesn't work on Imgur gifv links? #238

rruester opened this issue Jun 22, 2016 · 2 comments

Comments

@rruester
Copy link

rruester commented Jun 22, 2016 •
edited
Loading

When hovering over a .gifv link, TZP is requesting a .webm instead. Normally Imgur redirects these requests to the gifv image, but for TZP's requests Imgur returns a 404.

Edit - looks like it works on some links but not others. For example, it doesn't work on https://www.reddit.com/4pbw99/
@dadler
Copy link
Owner

dadler commented Jun 23, 2016

Yes, it looks like imgur.com changed their site and broke the ability for TZP to show pop-ups for gifv's. Imgur.com used to provide a corresponding webm when TZP changed .gifv to .webm. TZP did that since webm was a codec (format) which Firefox can show in a pop-up; gifv isn't. But now imgur.com doesn't provide webm format anymore; it just redirects to .gifv.

I may have to have it show .gif instead of .gifv or .webm, which would be unfortunate since it'd use more network bandwidth.

@dadler
Copy link
Owner

dadler commented Jan 2, 2017

I will soon prevent TZP from even trying to show pop-ups for gifv's (so at least we won't see an error icon).

dadler added a commit that referenced this issue Jan 2, 2017
@dadler
Disabled showing imgur.com *.gifv since doesn't work.
2e50cd0 
In June 2016 imgur.com changed their site so that gifv images
are no longer webm's, and won't display in a Firefox add-on
pop-up like TZP anymore.  To avoid just getting an error icon, we
no longer try to show pop-ups for gifv's.

An alternative would be to show them as .gif's, but they'd be
lower quality and use more bandwidth than if the user manually opened
the link.  Uncommenting the .gifv line would achieve that.

Related to #238.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dadler @rruester