Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update + whole caffe #3

Open
matthieudelaro opened this issue Jun 14, 2016 · 1 comment
Open

Update + whole caffe #3

matthieudelaro opened this issue Jun 14, 2016 · 1 comment

Comments

@matthieudelaro
Copy link

Hi,

thanks for your implementation, it's been really useful for my recent project.
I wonder though: why do you share only the files that you modified, instead of the whole caffe?

I took me some time to insert it into up-to-date caffe master (put files where they belong, modify caffe.proto, update your files to the structural changes of Caffe), so I share the final code for those who would be interested : https://github.com/matthieudelaro/caffeBVLCplus/tree/stn. It's an up-to-date, ready to compile caffe, including STN, and un-blocked CPU implementation (which leads me to another question: why did you disable the CPU implementation?). I'll consider working on a clean PR if your willing to merge it.

@daerduoCarey
Copy link
Owner

Thank you greatly for your work on this.

For your first question, I think it's easier to only share the files that I modified/added because you can merge them down without too much conflicts. Because my version of Caffe is not the latest one, my upload of other Caffe files may not be so useful.

For the second question, thanks so much for cleaning up my code and making it into new version of Caffe. The reason why I dropped the implementation for CPU version is that I found that I will mostly use my GPU version in my experiments and the CPU version is not fine-tuned and speeded up so much. So, I didn't share it.

Thank you again for your great job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants