Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_0 function #3

Open
Hugo-Attali opened this issue May 14, 2022 · 1 comment
Open

log_0 function #3

Hugo-Attali opened this issue May 14, 2022 · 1 comment

Comments

@Hugo-Attali
Copy link

hello,

Thank you very much for your work.

I think I misunderstood some things.
How can you guarantee that in the log_0 function, tanh^-1(sqrt(c) | y |) does not give an infinite result if sqrt(c) | y |>1 ?
Moreover I understood that hyperbolic space is defined by its negative curvature but in your work c > 0. What exactly is c?

Thank you very much !

@octavian-ganea
Copy link
Contributor

sqrt(c) | y | is always smaller than 1 as that is our definition of the Poincare disk (see our paper). The curvature is just -c, please check the notations in our paper or http://proceedings.mlr.press/v119/bachmann20a/bachmann20a.pdf .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants