Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: Pydantic v2 is breaking things #176

Closed
effigies opened this issue Apr 17, 2023 · 7 comments · Fixed by #203
Closed

FYI: Pydantic v2 is breaking things #176

effigies opened this issue Apr 17, 2023 · 7 comments · Fixed by #203
Assignees

Comments

@effigies
Copy link

Just a heads up that we're getting failures in PyBIDS on our pre-release tests due to a dependency using pydantic. A quick glance didn't indicate that you're testing pre-releases, so I wanted to make sure you weren't caught off-guard when the full release comes out.

@yarikoptic
Copy link
Member

Thank you @effigies for the heads up! I guess, while addressing incompatibility, we better add a dev run on CI here to also be able to be proactive. @jwodder -- please look into adding such a CI run and possibly fixing up any issue which might be arising? If no issues, I guess we would better still keep the upper bound before 2.0 you added in #177 until 2.0 is actually released, whenever we could boost it to < 3.0.

@yarikoptic
Copy link
Member

ok, @candleindark let's look into just migrating over to use pydantic 2.0 -- first approach here, and then see what it would take in the projects which use dandischema (see #178 (comment))

@candleindark
Copy link
Member

ok, @candleindark let's look into just migrating over to use pydantic 2.0 -- first approach here, and then see what it would take in the projects which use dandischema (see #178 (comment))

Do you mean migrating to Pydantic 2.0 for real now, without the support for Pydantic 1.0? Do you also mean to abandon the approach in #178? That approach supports Pydanic 1.0 by importing it though pydantic.v1 when Pydantic 2.0 is installed in the Python environment. It doesn't actually use Pydantic 2.0.

@satra
Copy link
Member

satra commented Nov 1, 2023

Do you mean migrating to Pydantic 2.0 for real now, without the support for Pydantic 1.0?

yup! no backwards compatibility wanted at this time.

@candleindark
Copy link
Member

Do you mean migrating to Pydantic 2.0 for real now, without the support for Pydantic 1.0?

yup! no backwards compatibility wanted at this time.

Great. That would be cleaner.

@yarikoptic
Copy link
Member

reconfirming -- full migration to v2 without using a shim

@oruebel
Copy link

oruebel commented Dec 11, 2023

FYI, this has come up as an issue here NeurodataWithoutBorders/pynwb#1799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants