New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output isn't semantic. #3

Closed

TravisBallard opened this issue Sep 7, 2019 · 1 comment

Contributor

TravisBallard commented Sep 7, 2019 •

edited

Loading

The output this generates is an unordered list with a bunch of nested buttons. Each button should be within a list-item.

current output:

<ul class="pagePagination">
  <button class="paginateButton paginationPrev">⬅️</button>
  <button class="">1</button>
  <button class="">2</button>
  <button class="">3</button>
  <button class="active">4</button>
  <button class="paginateButton paginationNext" disabled="">➡️</button>
</ul>

Should be:

<ul class="pagePagination">
  <li><button class="paginateButton paginationPrev">⬅️</button></li>
  <li><button class="">1</button></li>
  <li><button class="">2</button></li>
  <li><button class="">3</button></li>
  <li><button class="active">4</button></li>
  <li><button class="paginateButton paginationNext" disabled="">➡️</button></li>
</ul>

The text was updated successfully, but these errors were encountered:

Owner

dane-brown commented Sep 7, 2019

Thanks for pointing this out @TravisBallard . Resolved in @2.0.1

dane-brown closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment