Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update prune _debug to plot the other debug img #1619

Merged
merged 2 commits into from
Nov 4, 2024
Merged

update prune _debug to plot the other debug img #1619

merged 2 commits into from
Nov 4, 2024

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Debug call updated to actually display the colorized debug image.

Type of update
Is this a:

  • Bug fix
  • feature enhancement

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added update Updates an existing feature/method cleanup Code quality updates labels Oct 31, 2024
@HaleySchuhl HaleySchuhl self-assigned this Oct 31, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.6 milestone Oct 31, 2024
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Oct 31, 2024 •
edited
Loading

Here's the code health analysis summary for commits 2a2d811..da34f2b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl requested a review from k034b363 November 4, 2024 17:31
@nfahlgren nfahlgren merged commit fe0f508 into main Nov 4, 2024
5 checks passed
@nfahlgren nfahlgren deleted the morphology_prune_debug_bugfix branch November 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfahlgren nfahlgren nfahlgren approved these changes

@k034b363 k034b363 Awaiting requested review from k034b363

Assignees

@HaleySchuhl HaleySchuhl

Labels
cleanup Code quality updates ready to review update Updates an existing feature/method
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.6
Development

Successfully merging this pull request may close these issues.

pcv.morphology.prune debug image not getting displayed
2 participants
@HaleySchuhl @nfahlgren