Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto color correct wrapper #1625

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Nov 5, 2024

Describe your changes
Adds a wrapper that enables someone to do color corrections in one step.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added the update Updates an existing feature/method label Nov 5, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.6 milestone Nov 5, 2024
@HaleySchuhl HaleySchuhl self-assigned this Nov 5, 2024
Copy link

deepsource-io bot commented Nov 5, 2024

Here's the code health analysis summary for commits 1dbebaf..ce94abd. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

#### plantcv.transform.auto_correct_color

* pre v4.6: NA
* post v4.6: corrected_img = **plantcv.transform.r**(*rgb_img, label=None, **kwargs*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in function name

import cv2
import numpy as np
from plantcv.plantcv.transform import auto_correct_color

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@k034b363 k034b363 self-requested a review November 11, 2024 20:50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the example images for before and after color correction are different samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
Status: Pull Requests
Development

Successfully merging this pull request may close these issues.

3 participants