Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this work out-of-the-box with Unity 2019.4? #2

Open
DavidAntliff opened this issue Aug 4, 2021 · 3 comments
Open

Should this work out-of-the-box with Unity 2019.4? #2

DavidAntliff opened this issue Aug 4, 2021 · 3 comments

Comments

@DavidAntliff
Copy link

Hi, I'm working through your tutorial but I'm not able to get your example scene CompleteDemo to work with Unity 2019.4 (or 2020.3 for that matter either). I have a fresh clone of your master branch as of today.

I'm mostly presented with an overly white scene, although some trees can be seen:

image

image

When I run the scene, I seem to be rotating around a glaring white environment with obvious texture distortion and issues with face culling. Clicking the mouse buttons changes the name of the effect but there's no real visual change.

image

When importing the project I had to update ProBuilder to 4.4.0 to avoid a namespace clash, but I don't think that would cause the shaders to break.

Do you have any thoughts as to what is going wrong here? Have I missed a step somewhere? I'm using whatever the project was using originally, which is the BuiltIn RP I think.

@kayroice
Copy link

kayroice commented Feb 28, 2022

I get the same results with Unity 2021.2.13f1. Pretty sure what is happening is that OnRenderImage is no longer supported with the Scriptable Render Pipeline.

This project out of the box needs a Render Pipeline asset in order to be supported on newer versions of Unity (2020, 2021, etc.).

@daniel-ilett, any chance you could update this project to support URP (or just newer versions of Unity in general)?

@kayroice
Copy link

kayroice commented Feb 28, 2022

I verified that the shaders will work fine with Unity 2021.x and URP 12.x using URP_BlitRenderFeature. Anyone wanting to follow this tutorial using a more recent version of Unity and URP will need need to create a URP Render Asset and then add a URP Renderer Feature (or use the URP_BlitRenderFeature mentioned earlier) to the Render Asset they just created.

@timbuh
Copy link

timbuh commented Aug 12, 2024

@kayroice Would you mind sharing the project where this works? I spend a couple hours trying to get this to work but cant seem to go any further? Via the renderer feature it doesnt seem to recognise the render texture even after fixing the initial bugs and I have no clue how to implement it with the Blit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants