Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error into method SimpleEmailServiceRequest getParametersEncoded() #83

Open
vborduja opened this issue Mar 18, 2021 · 3 comments
Open

Comments

@vborduja
Copy link

vborduja commented Mar 18, 2021

Generates wrong parameter encoded when present parameters with ARRAY values
image

For example:
parameter Identities = ['addr1', 'addr2']
Into result we have query: Identities=addr1&Identies=addr2 - WRONG
Result must be with array definition: Identities[]=addr1&Identies[]=addr2

Why you don't use PHP native function http_build_query()
$query = http_build_query($this->parameters);

@vborduja
Copy link
Author

vborduja commented Mar 18, 2021

Seems like this method is not required any more, and could be replaced with
http_build_query($this->parameters, '', '&', PHP_QUERY_RFC3986);

Made PR: #84

@daniel-zahariev
Copy link
Owner

daniel-zahariev commented Mar 25, 2021

Hey @vborduja, thanks for the suggestion for using PHP's http_build_query function.
My tests showed that AWS accepts only PHP_QUERY_RFC1738 encryption type.
And i've pushed a new release (0.9.5) which should work for you.

@vborduja
Copy link
Author

Thank you @daniel-zahariev, there was also my or with PHP_QUERY_RFC1738, but it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants