New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change `okhttp-logging-interceptor` to `okhttp-interceptor-logging` + Same for Retrofit #1

Open

danielPerez97 opened this issue Mar 12, 2024 · 0 comments

Owner

danielPerez97 commented Mar 12, 2024

OkHttp can use multiple interceptor libraries. This change will keep things consistent in the libs.versions.toml

# Before
okhttp-1-interceptor = ...
okhttp-2-inteceptor = ...

# After
okhttp-interceptor-1=...
okhttp-interceptor-2=...
okhttp-interceptor-3=...

This simplifies the call sites:

dependencies {
    // Before
    libs.1.interceptor
    libs.2.interceptor

    // After
    libs.interceptor.1
    libs.interceptor.2
}

Same thing for Retrofit adapters + converters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment