Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain test vectors are not marked as binary #590

Open
1 of 3 tasks
supsm opened this issue Feb 9, 2025 · 0 comments
Open
1 of 3 tasks

Certain test vectors are not marked as binary #590

supsm opened this issue Feb 9, 2025 · 0 comments
Labels

Comments

@supsm
Copy link

supsm commented Feb 9, 2025

Describe the bug
Some test input files are not marked as binary (including but not limited to CBOR, BSON), so git will automatically add CR to any LF when cloning on windows with core.autocrlf=true, which breaks unit tests.

The files are marked as binary so git will not modify line endings.

Git modifies the line endings in the cases described above.

Enumerate the steps to reproduce the bug

  • Be on windows
  • Ensure core.autocrlf is set to true in git config (should be default)
  • Clone jsoncons
  • Build jsoncons
  • Run tests
  • Some tests fail

Include a small, self-contained example if possible
N/A

What compiler, architecture, and operating system?

  • Compiler: MSVC and GCC (wsl)
  • Architecture (e.g. x86, x64) x64
  • Operating system: Windows 11

What jsoncons library version?

  • Latest release 1.2.0
  • Other release ______
  • master
@supsm supsm added the Bug label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant