From b5b9528f92ca8dbc9f6a35884f269075ec522306 Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Fri, 20 Oct 2023 23:37:28 +0200
Subject: [PATCH 01/11] feat: scroll to new fields in the editor

---
 src/views/FormBuilder.svelte | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/src/views/FormBuilder.svelte b/src/views/FormBuilder.svelte
index 480f91e2..d9d8665b 100644
--- a/src/views/FormBuilder.svelte
+++ b/src/views/FormBuilder.svelte
@@ -26,6 +26,7 @@
 
     $: isValid = isValidFormDefinition(definition);
     $: errors = validateFields(definition.fields);
+    $: activeFieldIndex = 0;
 
     function folderField(element: HTMLElement, index: number) {
         const field = definition.fields[index];
@@ -45,6 +46,18 @@
         });
     }
 
+    function scrollWhenActive(element: HTMLElement, index: number) {
+        function update() {
+            if (index === activeFieldIndex) {
+                element.scrollIntoView({ behavior: "smooth", block: "center" });
+            }
+        }
+        update();
+        return {
+            update,
+        };
+    }
+
     function findFreeName(fieldIndex: number): string {
         const field = definition.fields[fieldIndex];
         let name = field.name;
@@ -130,7 +143,8 @@
                                 input: { type: "text" },
                             },
                         ];
-                        onChange();
+                        // onChange();
+                        activeFieldIndex = definition.fields.length - 1;
                     }}>Add more fields</button
                 >
                 <button
@@ -169,7 +183,10 @@
                 {#each definition.fields as field, index}
                     {@const desc_id = `desc_${index}`}
                     {@const delete_id = `delete_${index}`}
-                    <div class="flex column md-row gap2">
+                    <div
+                        class="flex column md-row gap2"
+                        use:scrollWhenActive={index}
+                    >
                         <div class="flex column gap1">
                             <label for={`name_${index}`}>Name</label>
                             <input

From 5d3f0ef9b66e854ec06a54f725798b20e465f00c Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 11:06:40 +0200
Subject: [PATCH 02/11] refactor: use folder input

---
 src/views/FormBuilder.svelte | 31 +++++--------------------------
 1 file changed, 5 insertions(+), 26 deletions(-)

diff --git a/src/views/FormBuilder.svelte b/src/views/FormBuilder.svelte
index d9d8665b..1fbbb21b 100644
--- a/src/views/FormBuilder.svelte
+++ b/src/views/FormBuilder.svelte
@@ -28,24 +28,6 @@
     $: errors = validateFields(definition.fields);
     $: activeFieldIndex = 0;
 
-    function folderField(element: HTMLElement, index: number) {
-        const field = definition.fields[index];
-        const inputType = field.input;
-        if (inputType.folder == null) {
-            inputType.folder = "";
-        }
-
-        new Setting(element).addSearch((search) => {
-            search.setPlaceholder("Select a folder");
-            search.setValue(inputType.folder || "");
-            new FolderSuggest(search.inputEl, app);
-            search.onChange((value) => {
-                inputType.folder = value;
-                onChange();
-            });
-        });
-    }
-
     function scrollWhenActive(element: HTMLElement, index: number) {
         function update() {
             if (index === activeFieldIndex) {
@@ -258,7 +240,6 @@
                                 notifyChange={onChange}
                                 is_multi={true}
                             />
-                            
                         {:else if field.input.type === "slider"}
                             {@const min_id = `min_${index}`}
                             {@const max_id = `max_${index}`}
@@ -281,13 +262,11 @@
                                 />
                             </div>
                         {:else if field.input.type === "note"}
-                            <!-- The autocomplete input will be inside the first div, so we remove some styles with the utility classes -->
-                            <div
-                                class="flex column gap1 remove-padding remove-border fix-suggest"
-                                use:folderField={index}
-                            >
-                                <label>Source Folder</label>
-                            </div>
+                            <InputFolder
+                                {index}
+                                bind:folder={field.input.folder}
+                                notifyChange={onChange}
+                            />
                         {:else if field.input.type === "dataview"}
                             <InputBuilderDataview
                                 {index}

From 57bc3f1881682509f255e0cf21cd2d8bc031d429 Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 11:22:19 +0200
Subject: [PATCH 03/11] refactor: extra defensive programming

---
 src/views/FormBuilder.svelte | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/src/views/FormBuilder.svelte b/src/views/FormBuilder.svelte
index 1fbbb21b..0c6f1fda 100644
--- a/src/views/FormBuilder.svelte
+++ b/src/views/FormBuilder.svelte
@@ -6,12 +6,12 @@
         FieldTypeReadable,
         validateFields,
     } from "src/core/formDefinition";
-    import { FolderSuggest } from "src/suggesters/suggestFolder";
-    import { setIcon, Setting, App } from "obsidian";
-    import FormRow from "./components/FormRow.svelte";
+    import { setIcon, App } from "obsidian";
     import InputBuilderDataview from "./components/inputBuilderDataview.svelte";
     import InputBuilderSelect from "./components/InputBuilderSelect.svelte";
     import InputFolder from "./components/InputFolder.svelte";
+    import { log_error } from "src/utils/Log";
+    import { ModalFormError } from "src/utils/Error";
 
     export let definition: EditableFormDefinition = {
         title: "",
@@ -42,6 +42,15 @@
 
     function findFreeName(fieldIndex: number): string {
         const field = definition.fields[fieldIndex];
+        if (!field) {
+            log_error(
+                new ModalFormError(
+                    "Unexpected error, no field at that index",
+                    fieldIndex + " leads to undefined"
+                )
+            );
+            return Date.now() + "";
+        }
         let name = field.name;
         const allNames = definition.fields.map((f) => f.name);
         let i = 1;
@@ -54,6 +63,15 @@
 
     function duplicateField(fieldIndex: number) {
         const field = definition.fields[fieldIndex];
+        if (!field) {
+            log_error(
+                new ModalFormError(
+                    "Unexpected error, no field at that index",
+                    fieldIndex + " leads to undefined"
+                )
+            );
+            return;
+        }
         const newField = {
             ...field,
             input: structuredClone(field.input),
@@ -71,7 +89,9 @@
         const to = direction === "up" ? from - 1 : from + 1;
         if (to < 0 || to >= definition.fields.length) return;
         const tmp = definition.fields[from];
-        definition.fields[from] = definition.fields[to];
+        const target = definition.fields[to];
+        if (!target || !tmp) return;
+        definition.fields[from] = target;
         definition.fields[to] = tmp;
         definition.fields = definition.fields;
         onChange();

From 31c66831f0d698d7773f41757260d558e51cec79 Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 12:01:33 +0200
Subject: [PATCH 04/11] fix: type check also svelte files

---
 package-lock.json                             | 123 +++++++++++++++++-
 package.json                                  |   5 +-
 .../components/InputBuilderSelect.svelte      |  68 +++++-----
 tsconfig.json                                 |   8 +-
 4 files changed, 160 insertions(+), 44 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 2b004a1e..4adfb9cd 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
     "name": "obsidian-modal-form",
-    "version": "1.16.5",
+    "version": "1.17.0",
     "lockfileVersion": 3,
     "requires": true,
     "packages": {
         "": {
             "name": "obsidian-modal-form",
-            "version": "1.16.5",
+            "version": "1.17.0",
             "license": "MIT",
             "dependencies": {
                 "fuse.js": "^6.6.2",
@@ -24,6 +24,7 @@
                 "jest": "^29.7.0",
                 "obsidian": "^1.4.11",
                 "svelte": "^4.2.0",
+                "svelte-check": "^3.5.2",
                 "svelte-preprocess": "^5.0.4",
                 "ts-jest": "^29.1.1",
                 "ts-node": "^10.9.1",
@@ -2344,6 +2345,15 @@
             "integrity": "sha512-3oSeUO0TMV67hN1AmbXsK4yaqU7tjiHlbxRDZOpH0KW9+CeX4bRAaX0Anxt0tx2MrpRpWwQaPwIlISEJhYU5Pw==",
             "dev": true
         },
+        "node_modules/binary-extensions": {
+            "version": "2.2.0",
+            "resolved": "https://registry.npmjs.org/binary-extensions/-/binary-extensions-2.2.0.tgz",
+            "integrity": "sha512-jDctJ/IVQbZoJykoeHbhXpOlNBqGNcwXJKJog42E5HDPUwQTSdjCHdihjj0DlnheQ7blbT6dHOafNAiS8ooQKA==",
+            "dev": true,
+            "engines": {
+                "node": ">=8"
+            }
+        },
         "node_modules/brace-expansion": {
             "version": "1.1.11",
             "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz",
@@ -2509,6 +2519,45 @@
                 "node": ">=10"
             }
         },
+        "node_modules/chokidar": {
+            "version": "3.5.3",
+            "resolved": "https://registry.npmjs.org/chokidar/-/chokidar-3.5.3.tgz",
+            "integrity": "sha512-Dr3sfKRP6oTcjf2JmUmFJfeVMvXBdegxB0iVQ5eb2V10uFJUCAS8OByZdVAyVb8xXNz3GjjTgj9kLWsZTqE6kw==",
+            "dev": true,
+            "funding": [
+                {
+                    "type": "individual",
+                    "url": "https://paulmillr.com/funding/"
+                }
+            ],
+            "dependencies": {
+                "anymatch": "~3.1.2",
+                "braces": "~3.0.2",
+                "glob-parent": "~5.1.2",
+                "is-binary-path": "~2.1.0",
+                "is-glob": "~4.0.1",
+                "normalize-path": "~3.0.0",
+                "readdirp": "~3.6.0"
+            },
+            "engines": {
+                "node": ">= 8.10.0"
+            },
+            "optionalDependencies": {
+                "fsevents": "~2.3.2"
+            }
+        },
+        "node_modules/chokidar/node_modules/glob-parent": {
+            "version": "5.1.2",
+            "resolved": "https://registry.npmjs.org/glob-parent/-/glob-parent-5.1.2.tgz",
+            "integrity": "sha512-AOIgSQCepiJYwP3ARnGx+5VnTu2HBYdzbGP45eLw1vr3zB3vZLeyed1sC9hnbcOc9/SrMyM5RPQrkGz4aS9Zow==",
+            "dev": true,
+            "dependencies": {
+                "is-glob": "^4.0.1"
+            },
+            "engines": {
+                "node": ">= 6"
+            }
+        },
         "node_modules/ci-info": {
             "version": "3.9.0",
             "resolved": "https://registry.npmjs.org/ci-info/-/ci-info-3.9.0.tgz",
@@ -3451,7 +3500,6 @@
             "resolved": "https://registry.npmjs.org/import-fresh/-/import-fresh-3.3.0.tgz",
             "integrity": "sha512-veYYhQa+D1QBKznvhUHxb8faxlrwUnxseDAbAp457E0wLNio2bOSKnjYDhMj+YiAq61xrMGhQk9iXVk5FzgQMw==",
             "dev": true,
-            "peer": true,
             "dependencies": {
                 "parent-module": "^1.0.0",
                 "resolve-from": "^4.0.0"
@@ -3513,6 +3561,18 @@
             "integrity": "sha512-zz06S8t0ozoDXMG+ube26zeCTNXcKIPJZJi8hBrF4idCLms4CG9QtK7qBl1boi5ODzFpjswb5JPmHCbMpjaYzg==",
             "dev": true
         },
+        "node_modules/is-binary-path": {
+            "version": "2.1.0",
+            "resolved": "https://registry.npmjs.org/is-binary-path/-/is-binary-path-2.1.0.tgz",
+            "integrity": "sha512-ZMERYes6pDydyuGidse7OsHxtbI7WVeUEozgR/g7rd0xUimYNlvZRE/K2MgZTjWy725IfelLeVcEM97mmtRGXw==",
+            "dev": true,
+            "dependencies": {
+                "binary-extensions": "^2.0.0"
+            },
+            "engines": {
+                "node": ">=8"
+            }
+        },
         "node_modules/is-core-module": {
             "version": "2.13.0",
             "resolved": "https://registry.npmjs.org/is-core-module/-/is-core-module-2.13.0.tgz",
@@ -4532,6 +4592,15 @@
                 "node": "*"
             }
         },
+        "node_modules/mri": {
+            "version": "1.2.0",
+            "resolved": "https://registry.npmjs.org/mri/-/mri-1.2.0.tgz",
+            "integrity": "sha512-tzzskb3bG8LvYGFF/mDTpq3jpI6Q9wc3LEmBaghu+DdCssd1FakN7Bc0hVNmEyGq1bq3RgfkCb3cmQLpNPOroA==",
+            "dev": true,
+            "engines": {
+                "node": ">=4"
+            }
+        },
         "node_modules/ms": {
             "version": "2.1.2",
             "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.2.tgz",
@@ -4678,7 +4747,6 @@
             "resolved": "https://registry.npmjs.org/parent-module/-/parent-module-1.0.1.tgz",
             "integrity": "sha512-GQ2EWRpQV8/o+Aw8YqtfZZPfNRWZYkbidE9k5rpl/hC3vtHHBfGm2Ifi6qWV+coDGkrUKZAxE3Lot5kcsRlh+g==",
             "dev": true,
-            "peer": true,
             "dependencies": {
                 "callsites": "^3.0.0"
             },
@@ -4949,6 +5017,18 @@
             "integrity": "sha512-xWGDIW6x921xtzPkhiULtthJHoJvBbF3q26fzloPCK0hsvxtPVelvftw3zjbHWSkR2km9Z+4uxbDDK/6Zw9B8w==",
             "dev": true
         },
+        "node_modules/readdirp": {
+            "version": "3.6.0",
+            "resolved": "https://registry.npmjs.org/readdirp/-/readdirp-3.6.0.tgz",
+            "integrity": "sha512-hOS089on8RduqdbhvQ5Z37A0ESjsqz6qnRcffsMU3495FuTdqSm+7bhJ29JvIOsBDEEnan5DPu9t3To9VRlMzA==",
+            "dev": true,
+            "dependencies": {
+                "picomatch": "^2.2.1"
+            },
+            "engines": {
+                "node": ">=8.10.0"
+            }
+        },
         "node_modules/require-directory": {
             "version": "2.1.1",
             "resolved": "https://registry.npmjs.org/require-directory/-/require-directory-2.1.1.tgz",
@@ -5001,7 +5081,6 @@
             "resolved": "https://registry.npmjs.org/resolve-from/-/resolve-from-4.0.0.tgz",
             "integrity": "sha512-pb/MYmXstAkysRFx8piNI1tGFNQIFA3vkE3Gq4EuA1dF6gHp/+vgZqsCGJapvy8N3Q+4o7FwvquPJcnZ7RYy4g==",
             "dev": true,
-            "peer": true,
             "engines": {
                 "node": ">=4"
             }
@@ -5064,6 +5143,18 @@
                 "queue-microtask": "^1.2.2"
             }
         },
+        "node_modules/sade": {
+            "version": "1.8.1",
+            "resolved": "https://registry.npmjs.org/sade/-/sade-1.8.1.tgz",
+            "integrity": "sha512-xal3CZX1Xlo/k4ApwCFrHVACi9fBqJ7V+mwhBsuf/1IOKbBy098Fex+Wa/5QMubw09pSZ/u8EY8PWgevJsXp1A==",
+            "dev": true,
+            "dependencies": {
+                "mri": "^1.1.0"
+            },
+            "engines": {
+                "node": ">=6"
+            }
+        },
         "node_modules/sander": {
             "version": "0.5.1",
             "resolved": "https://registry.npmjs.org/sander/-/sander-0.5.1.tgz",
@@ -5351,6 +5442,28 @@
                 "node": ">=16"
             }
         },
+        "node_modules/svelte-check": {
+            "version": "3.5.2",
+            "resolved": "https://registry.npmjs.org/svelte-check/-/svelte-check-3.5.2.tgz",
+            "integrity": "sha512-5a/YWbiH4c+AqAUP+0VneiV5bP8YOk9JL3jwvN+k2PEPLgpu85bjQc5eE67+eIZBBwUEJzmO3I92OqKcqbp3fw==",
+            "dev": true,
+            "dependencies": {
+                "@jridgewell/trace-mapping": "^0.3.17",
+                "chokidar": "^3.4.1",
+                "fast-glob": "^3.2.7",
+                "import-fresh": "^3.2.1",
+                "picocolors": "^1.0.0",
+                "sade": "^1.7.4",
+                "svelte-preprocess": "^5.0.4",
+                "typescript": "^5.0.3"
+            },
+            "bin": {
+                "svelte-check": "bin/svelte-check"
+            },
+            "peerDependencies": {
+                "svelte": "^3.55.0 || ^4.0.0-next.0 || ^4.0.0"
+            }
+        },
         "node_modules/svelte-preprocess": {
             "version": "5.0.4",
             "resolved": "https://registry.npmjs.org/svelte-preprocess/-/svelte-preprocess-5.0.4.tgz",
diff --git a/package.json b/package.json
index 70b515d9..0cb5f113 100644
--- a/package.json
+++ b/package.json
@@ -6,7 +6,7 @@
     "scripts": {
         "dev": "node esbuild.config.mjs",
         "build": "tsc -noEmit -skipLibCheck && node esbuild.config.mjs production",
-        "check": "tsc --noEmit",
+        "check": "svelte-check --tsconfig tsconfig.json",
         "test": "jest",
         "version": "node version-bump.mjs && git add manifest.json versions.json"
     },
@@ -25,6 +25,7 @@
         "jest": "^29.7.0",
         "obsidian": "^1.4.11",
         "svelte": "^4.2.0",
+        "svelte-check": "^3.5.2",
         "svelte-preprocess": "^5.0.4",
         "ts-jest": "^29.1.1",
         "ts-node": "^10.9.1",
@@ -35,4 +36,4 @@
         "fuse.js": "^6.6.2",
         "valibot": "^0.19.0"
     }
-}
+}
\ No newline at end of file
diff --git a/src/views/components/InputBuilderSelect.svelte b/src/views/components/InputBuilderSelect.svelte
index 4b3ab7ab..ab40ad13 100644
--- a/src/views/components/InputBuilderSelect.svelte
+++ b/src/views/components/InputBuilderSelect.svelte
@@ -3,6 +3,7 @@
      * This component is specific for the input builder,
      * specifically to build the select input type
      */
+    type option = { label: string; value: string } | string;
 
     import { setIcon } from "obsidian";
     import FormRow from "./FormRow.svelte";
@@ -12,7 +13,7 @@
     export let index: number;
     export let source: string = "fixed";
     export let folder: string | undefined;
-    export let options: EditableInput["options"] = [];
+    export let options: option[] = [];
     export let notifyChange: () => void;
     export let is_multi: boolean;
     $: id = `builder_select_${index}`;
@@ -21,8 +22,10 @@
     function moveOption(from: number, direction: "up" | "down") {
         const to = direction === "up" ? from - 1 : from + 1;
         if (to < 0 || to >= options.length) return;
-        const tmp = options[from]
-        options[from] = options[to]
+        const tmp = options[from];
+        const target = options[to];
+        if (!target || !tmp) return;
+        options[from] = target;
         options[to] = tmp;
         options = options;
         notifyChange();
@@ -40,7 +43,7 @@
         <button
             type="button"
             on:click={() => {
-                if (is_multi) { 
+                if (is_multi) {
                     options?.push("");
                 } else {
                     options?.push({ value: "", label: "" });
@@ -76,33 +79,32 @@
                         on:click={() => moveOption(idx, "down")}
                     /></FormRow
                 >
-                {#if is_multi }
-                <FormRow label="Value" id={value_id}>
-                    <input
-                        type="text"
-                        placeholder="Value"
-                        bind:value={option}
-                        id={value_id}
-                    /></FormRow
-                >
+                {#if is_multi}
+                    <FormRow label="Value" id={value_id}>
+                        <input
+                            type="text"
+                            placeholder="Value"
+                            bind:value={option}
+                            id={value_id}
+                        /></FormRow
+                    >
                 {:else}
-                {@const label_id = `${options_id}_option_label_${idx}`}
-                <FormRow label="Label" id={label_id}>
-                    <input
-                        type="text"
-                        placeholder="Label"
-                        bind:value={option.label}
-                        id={label_id}
-                    /></FormRow
-                ><FormRow label="Value" id={value_id}>
-                    <input
-                        type="text"
-                        placeholder="Value"
-                        bind:value={option.value}
-                        id={value_id}
-                    /></FormRow
-                >
-                
+                    {@const label_id = `${options_id}_option_label_${idx}`}
+                    <FormRow label="Label" id={label_id}>
+                        <input
+                            type="text"
+                            placeholder="Label"
+                            bind:value={option.label}
+                            id={label_id}
+                        /></FormRow
+                    ><FormRow label="Value" id={value_id}>
+                        <input
+                            type="text"
+                            placeholder="Value"
+                            bind:value={option.value}
+                            id={value_id}
+                        /></FormRow
+                    >
                 {/if}
                 <FormRow
                     label="Delete"
@@ -128,7 +130,7 @@
 
 <style>
     button:disabled {
-    opacity: 0.5;
-    cursor: forbidden;
-}
+        opacity: 0.5;
+        cursor: forbidden;
+    }
 </style>
diff --git a/tsconfig.json b/tsconfig.json
index f4999604..e265fb81 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -15,9 +15,9 @@
         "strict": true,
         "noUncheckedIndexedAccess": true,
         "types": [
-            "svelte",
+            "jest",
             "node",
-            "jest"
+            "svelte",
         ],
         "lib": [
             "DOM",
@@ -27,6 +27,6 @@
         ]
     },
     "include": [
-        "**/*.ts"
+        "src/**/*",
     ]
-}
+}
\ No newline at end of file

From ec0da80c529984a938e0bbc95a2938ecd742c196 Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 12:01:51 +0200
Subject: [PATCH 05/11] refactor: remove unused

---
 src/core/formDefinition.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/formDefinition.ts b/src/core/formDefinition.ts
index 16b78006..f7654357 100644
--- a/src/core/formDefinition.ts
+++ b/src/core/formDefinition.ts
@@ -1,4 +1,4 @@
-import { object, number, literal, type Output, is, array, string, union, optional, safeParse, minLength, toTrimmed, flatten } from "valibot";
+import { object, number, literal, type Output, is, array, string, union, optional, safeParse, minLength, toTrimmed } from "valibot";
 /**
  * Here are the core logic around the main domain of the plugin,
  * which is the form definition.

From 9357589495ee0b2ae8935d70b841eab3c1d725d0 Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 12:37:18 +0200
Subject: [PATCH 06/11] fix: ensure types in svelte at build

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 0cb5f113..fa34432f 100644
--- a/package.json
+++ b/package.json
@@ -5,7 +5,7 @@
     "main": "main.js",
     "scripts": {
         "dev": "node esbuild.config.mjs",
-        "build": "tsc -noEmit -skipLibCheck && node esbuild.config.mjs production",
+        "build": "npm run check && node esbuild.config.mjs production",
         "check": "svelte-check --tsconfig tsconfig.json",
         "test": "jest",
         "version": "node version-bump.mjs && git add manifest.json versions.json"

From 03aded14505485354c4612863e302b0d2b33be0a Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 13:00:43 +0200
Subject: [PATCH 07/11] refactor: run tests

---
 .github/workflows/pull-request.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .github/workflows/pull-request.yml

diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
new file mode 100644
index 00000000..8f9b54da
--- /dev/null
+++ b/.github/workflows/pull-request.yml
@@ -0,0 +1,11 @@
+name: Build and Test
+on:
+    pull_request:
+
+jobs:
+    build:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v3
+            - name: Build and Test
+              run: npm run build && npm run test

From 903738be0af4923a268acc344285cb11e40789fe Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 13:08:23 +0200
Subject: [PATCH 08/11] fix: pipelines install

---
 .github/workflows/pull-request.yml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
index 8f9b54da..a5ed15a4 100644
--- a/.github/workflows/pull-request.yml
+++ b/.github/workflows/pull-request.yml
@@ -7,5 +7,11 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v3
+            - name: Use Node.js
+              uses: actions/setup-node@v3
+              with:
+                  cache: "npm"
+
+            - run: npm install
             - name: Build and Test
               run: npm run build && npm run test

From 3be12bf8d521fba3d5cccc00e441fc7a662081ba Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sat, 21 Oct 2023 13:09:36 +0200
Subject: [PATCH 09/11] fix: type narrow on svelte

---
 src/views/components/InputBuilderSelect.svelte | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/views/components/InputBuilderSelect.svelte b/src/views/components/InputBuilderSelect.svelte
index ab40ad13..3ace3e86 100644
--- a/src/views/components/InputBuilderSelect.svelte
+++ b/src/views/components/InputBuilderSelect.svelte
@@ -8,7 +8,6 @@
     import { setIcon } from "obsidian";
     import FormRow from "./FormRow.svelte";
     import InputFolder from "./InputFolder.svelte";
-    import type { EditableInput } from "src/core/formDefinition";
 
     export let index: number;
     export let source: string = "fixed";
@@ -79,7 +78,7 @@
                         on:click={() => moveOption(idx, "down")}
                     /></FormRow
                 >
-                {#if is_multi}
+                {#if "string" == typeof option}
                     <FormRow label="Value" id={value_id}>
                         <input
                             type="text"

From 19084b5256927562f9fcc934629370813880128b Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sun, 22 Oct 2023 13:45:54 +0200
Subject: [PATCH 10/11] feat: scroll to elements on the list

---
 src/core/formDefinition.ts   |  5 ++++-
 src/views/FormBuilder.svelte | 26 +++++++++++++++++++-------
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/src/core/formDefinition.ts b/src/core/formDefinition.ts
index f7654357..3aa733b9 100644
--- a/src/core/formDefinition.ts
+++ b/src/core/formDefinition.ts
@@ -170,7 +170,10 @@ export function validateFields(fields: unknown) {
     }
     console.error('Fields issues', result.issues)
     return result.issues.map(issue =>
-        ({ message: issue.message, path: issue.path?.map(item => item.key).join('.') })
+    ({
+        message: issue.message, path: issue.path?.map(item => item.key).join('.'),
+        index: issue.path?.[0]?.key ?? 0
+    })
     );
 }
 
diff --git a/src/views/FormBuilder.svelte b/src/views/FormBuilder.svelte
index 0c6f1fda..cff98fe6 100644
--- a/src/views/FormBuilder.svelte
+++ b/src/views/FormBuilder.svelte
@@ -18,7 +18,6 @@
         name: "",
         fields: [],
     };
-    export let app: App;
     export let onChange: () => void;
     export let onSubmit: (formDefinition: FormDefinition) => void;
     export let onCancel: () => void;
@@ -28,13 +27,18 @@
     $: errors = validateFields(definition.fields);
     $: activeFieldIndex = 0;
 
-    function scrollWhenActive(element: HTMLElement, index: number) {
-        function update() {
-            if (index === activeFieldIndex) {
-                element.scrollIntoView({ behavior: "smooth", block: "center" });
+    function scrollWhenActive(element: HTMLElement, isActive: boolean) {
+        function update(isActive: boolean) {
+            if (isActive) {
+                setTimeout(() => {
+                    element.scrollIntoView({
+                        behavior: "smooth",
+                        block: "center",
+                    });
+                }, 100);
             }
         }
-        update();
+        update(isActive);
         return {
             update,
         };
@@ -83,6 +87,7 @@
             ...definition.fields.slice(fieldIndex + 1),
         ];
         onChange();
+        activeFieldIndex = fieldIndex + 1;
     }
 
     function moveField(from: number, direction: "up" | "down") {
@@ -95,6 +100,7 @@
         definition.fields[to] = tmp;
         definition.fields = definition.fields;
         onChange();
+        activeFieldIndex = to;
     }
 
     const handleSubmit = () => {
@@ -173,6 +179,12 @@
                             {#if error.path}
                                 at {error.path}
                             {/if}
+                            <button
+                                type="button"
+                                on:click={() => {
+                                    activeFieldIndex = error.index;
+                                }}>Go to problem</button
+                            >
                         </li>
                     {/each}
                 </ul>
@@ -187,7 +199,7 @@
                     {@const delete_id = `delete_${index}`}
                     <div
                         class="flex column md-row gap2"
-                        use:scrollWhenActive={index}
+                        use:scrollWhenActive={index === activeFieldIndex}
                     >
                         <div class="flex column gap1">
                             <label for={`name_${index}`}>Name</label>

From 0c4b077092fa08440930c89fafc32db02da8579a Mon Sep 17 00:00:00 2001
From: Danielo Rodriguez <rdanielo@gmail.com>
Date: Sun, 22 Oct 2023 13:51:23 +0200
Subject: [PATCH 11/11] fix: accept empty option values for now

---
 src/core/formDefinition.ts | 2 +-
 src/views/EditFormView.ts  | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/core/formDefinition.ts b/src/core/formDefinition.ts
index 3aa733b9..b02d8147 100644
--- a/src/core/formDefinition.ts
+++ b/src/core/formDefinition.ts
@@ -32,7 +32,7 @@ const InputSelectFixedSchema = object({
     type: literal("select"),
     source: literal("fixed"),
     options: array(object({
-        value: nonEmptyString('Value of a select option'), label: string()
+        value: string([toTrimmed()]), label: string()
     }))
 });
 
diff --git a/src/views/EditFormView.ts b/src/views/EditFormView.ts
index 2b179559..7fecc2b2 100644
--- a/src/views/EditFormView.ts
+++ b/src/views/EditFormView.ts
@@ -46,7 +46,6 @@ export class EditFormView extends ItemView {
             target: this.containerEl,
             props: {
                 definition: this.formState,
-                app: this.app,
                 onChange: () => {
                     console.log(this.formState)
                     this.app.workspace.requestSaveLayout()