Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate dependencies from JS/CSS code #5

Open
alexcasalboni opened this issue Sep 11, 2017 · 4 comments
Open

Separate dependencies from JS/CSS code #5

alexcasalboni opened this issue Sep 11, 2017 · 4 comments

Comments

@alexcasalboni
Copy link
Collaborator

I would make clear what is a library/dependency and what's part of the repo. Eventually, we could add a bit of dependency management and injection (npm, bower, browserify, gulp, webpack, etc.).

@danilop
Copy link
Owner

danilop commented Sep 11, 2017

I agree, the reason I included the source JS/CSS files for the dependacies was that I still wanted people to be able to clone the repo and start using it locally, without having to use a too such as npm/bower to install the dependencies.

@fblecha
Copy link

fblecha commented Sep 11, 2017

I like that everything needed to use the tool was available locally. I do a lot of programming on trains/buses with intermittent internet.

@rts-rob
Copy link
Contributor

rts-rob commented Sep 11, 2017

PR #2 adds in browserify which I suggest is a good middle ground. If we upload bundle.js (as the PR does) then it's ready to run locally without any additional commands as soon as the user clones it, but we still get the modularity of browserify (which I used to avoid name collisions between the engines).

@alexcasalboni
Copy link
Collaborator Author

@fblecha @rts-rob I'm not necessarily suggesting to use CDNs for external libraries. I am suggesting to remove them from the repo and use a proper dependency management tool.
This way, you'd only install dependencies once at clone-time. Also, we'll be able to update libs versions over time without manually copying huge files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants