-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for multiframe KITTY_SELFREF made it slooooooooooooooow #2161
Comments
backing off to |
though guess what... |
so ideas include (these all need inspection of the protocol to see if they'd work):
|
we've got these just about handled with my latest fix. |
ok, figured out the so i think we need to recognize whether we blitted the original frame with nulls. if we did, use |
yep, works perfectly, w00t! |
Much as we needed to do in the accounting core for kitty animation, whether we blitted a sprixcell of alpha nulls or instead wiped it affects how we rebuild under KITTY_ANIMATION, which right now is all Kitty >= 0.20.0 since KITTY_SELFREF is disabled. This gets KITTY_ANIMATION working perfectly on bitmapstates. I've accomplished this by stashing a bool onto the end of each KITTY_ANIMATION-style auxvector, set high if it originated in a reblit's null alphas, and low if it was zorched by a wipe. Set {c, r} arguments to animation directive based on whether this is set. See #2161.
The fix for #2143 led to unacceptable slowdown in the
yield
demo. On "grimes", my T580 laptop, the 2.4.0 release runs in 53.33s. Current master runs in 117.74s, almost a 100% slowdown! erp!The text was updated successfully, but these errors were encountered: