From 36b39bf73f71a991f4e01b5be534d772e8f8dca5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Jeanneret?= <cjeanner@redhat.com>
Date: Wed, 3 Jul 2024 15:02:43 +0200
Subject: [PATCH] Enable some debugging if no DNS records

It seems some scenarios might lead to no DNS records. This isn't normal,
and we need to know why we're hitting that issue.

This patch should help tracking down the issue.
---
 .../tasks/reserve_dnsmasq_ips.yml             | 121 +++++++++++-------
 1 file changed, 78 insertions(+), 43 deletions(-)

diff --git a/roles/libvirt_manager/tasks/reserve_dnsmasq_ips.yml b/roles/libvirt_manager/tasks/reserve_dnsmasq_ips.yml
index 07c1526dfa..6741be2f1b 100644
--- a/roles/libvirt_manager/tasks/reserve_dnsmasq_ips.yml
+++ b/roles/libvirt_manager/tasks/reserve_dnsmasq_ips.yml
@@ -42,25 +42,8 @@
     label: "{{ host_data.key }} - {{ net.name }}"
     loop_var: "host_data"
 
-- name: Create host records
-  when:
-    - host_data.value.networks[_cleaned_netname] is defined
+- name: Manage common parameters
   vars:
-    _net_name: >-
-      {{ (net.name is match '.*osp_trunk$') | ternary('ctlplane', net.name) }}
-    _cleaned_netname: "{{ _net_name | regex_replace('^cifmw[_-]', '') }}"
-    _net_data: "{{ host_data.value.networks[_cleaned_netname] }}"
-    _ocp_name: >-
-      {{
-        host_data.key | replace('_', '-') |
-        replace('ocp-worker', 'worker') |
-        replace('ocp', 'master')
-      }}
-    _hostname: >-
-      {{
-        (host_data.key is match('^ocp.*')) |
-        ternary(_ocp_name, host_data.key)
-      }}
     _translate: >-
       {{ cifmw_networking_mapper_interfaces_info_translations | default({}) }}
     _net_domain: >-
@@ -68,33 +51,85 @@
         (net.name in _translate) |
         ternary(_translate[net.name], [net.name])
       }}
-    _fqdn: >-
-      {%- if net.name == cifmw_libvirt_manager_pub_net -%}
-      {{ [_hostname ~ '.' ~ cifmw_reproducer_domain | default('local')] }}
-      {%- else -%}
-      {{
-        [_hostname] | product(_net_domain) |
-        map('join', '.') |
-        product([cifmw_reproducer_domain | default('local')]) |
-        map('join', '.')
-      }}
-      {%- endif -%}
-    _record:
-      - state: present
-        ips: >-
+    _net_name: >-
+      {{ (net.name is match '.*osp_trunk$') | ternary('ctlplane', net.name) }}
+    _cleaned_netname: "{{ _net_name | regex_replace('^cifmw[_-]', '') }}"
+  block:
+    - name: Create host records
+      when:
+        - host_data.value.networks[_cleaned_netname] is defined
+      vars:
+        _net_data: "{{ host_data.value.networks[_cleaned_netname] }}"
+        _ocp_name: >-
           {{
-            [
-              _net_data.ip_v4 | default(''),
-              _net_data.ip_v6 | default('')
-            ]
+            host_data.key | replace('_', '-') |
+            replace('ocp-worker', 'worker') |
+            replace('ocp', 'master')
           }}
-        names: "{{ _fqdn }}"
-  ansible.builtin.set_fact:
-    host_records: "{{ host_records | default([]) + _record }}"
-  loop: "{{ cifmw_networking_env_definition.instances | dict2items }}"
-  loop_control:
-    label: "{{ host_data.key }} - {{ net.name }}"
-    loop_var: "host_data"
+        _hostname: >-
+          {{
+            (host_data.key is match('^ocp.*')) |
+            ternary(_ocp_name, host_data.key)
+          }}
+        _fqdn: >-
+          {%- if net.name == cifmw_libvirt_manager_pub_net -%}
+          {{ [_hostname ~ '.' ~ cifmw_reproducer_domain | default('local')] }}
+          {%- else -%}
+          {{
+            [_hostname] | product(_net_domain) |
+            map('join', '.') |
+            product([cifmw_reproducer_domain | default('local')]) |
+            map('join', '.')
+          }}
+          {%- endif -%}
+        _record:
+          - state: present
+            ips: >-
+              {{
+                [
+                  _net_data.ip_v4 | default(''),
+                  _net_data.ip_v6 | default('')
+                ]
+              }}
+            names: "{{ _fqdn }}"
+      ansible.builtin.set_fact:
+        host_records: "{{ host_records | default([]) + _record }}"
+      loop: "{{ cifmw_networking_env_definition.instances | dict2items }}"
+      loop_control:
+        label: "{{ host_data.key }} - {{ net.name }}"
+        loop_var: "host_data"
+
+    - name: Debugging block/rescue
+      block:
+        - name: Assert we have records
+          ansible.builtin.assert:
+            that:
+              - host_records is defined
+
+      rescue:
+        - name: Debug net.name
+          ansible.builtin.debug:
+            msg: "net.name: {{ net.name }}"
+
+        - name: Debug _translate
+          ansible.builtin.debug:
+            var: _translate
+
+        - name: Debug _net_domain
+          ansible.builtin.debug:
+            var: _net_domain
+
+        - name: Debug _net_name
+          ansible.builtin.debug:
+            var: _net_name
+
+        - name: Debug _cleaned_netname
+          ansible.builtin.debug:
+            var: _cleaned_netname
+
+        - name: Fail for good
+          ansible.builtin.fail:
+            msg: "Error detected, please check debug above"
 
 - name: Inject host records
   vars: