-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] dark mode for admin panel #809
Comments
Current adminlte css (htmly) is around 674KB, let me see the newest version. We have minimal modification to the old adminlte so just replace the CSS it should be fine. |
Yeah, just because of rather small css file size in htmly I had mixed feelings using the full 1,3MB updated CSS file containing light+dark modes. I never got into SASS/LESS thingy thus I can't say if it's possible to compile only darkmode css file for adminlte. Pity that the package contains distributable standalone light version without standalone dark one. |
Seems I've overlooked one window. Preview window would have to get along with it, top navbar with search could also become dark After reading all opened issues, seems that dark mode has already been requested in f.e. #718 |
I merged 3 css files from adminlte 3.2 to make css as light as possible (still takes ~1MB). Editor buttons are generated by javascript thus I have to find a workaround. Any feedback would be appreciated as I might have missed something. |
@danpros |
@Joduai thank you for this. I have released this feature in 3.0.2. There seems to be no need for a third option, the current options are more than enough. |
I wondered how could I enable dark mode in admin panel, assuming AdminLTE dashboard offers such function.
Unfortunately htmly utilizes v.3.0.5 of ALTE, and dark mode was implemented in newer, 3.1 version.
Uploading newer ALTE css and adding "dark-mode" class to
<body>
in system/admin/view/layout.html.php seems to do the job.Only 2 light elements I've found are on the screenshot, but they do not hurt the eyes.
If there weren't any elements with custom css, updating css file should work right away.
This leads to a question: how about adding dark mode function to htmly?
Maybe as a config option, rather than a clickable switch like front end templates offer nowadays?
Why?
Full distributable css with both light, and dark modes weights minified ~1,3MB. There's also a standalone light version that weighs half that size. But there's no standalone css dist file for darkmode, thus such biggie could be loaded only when somebody wants to get dark mode in admin panel. Maybe using mixins to get standalone dark mode and then switch between 2 separate css files would do it, but would it be worth the hassle?
The text was updated successfully, but these errors were encountered: