From 71d644a2fd02fba3b98cd6848a15402d5ac195c4 Mon Sep 17 00:00:00 2001 From: hassan Al-khafagy <72603041+hassony105@users.noreply.github.com> Date: Thu, 22 Aug 2024 09:19:55 +0300 Subject: [PATCH] Fix unnamed function parameters (#1309) --- packages/core/lib/src/core_html_widget.dart | 4 ++-- packages/core/lib/src/internal/flattener.dart | 3 ++- packages/core/lib/src/internal/margin_vertical.dart | 4 +++- packages/core/lib/src/internal/ops/tag_table.dart | 2 +- packages/core/lib/src/widgets/html_details.dart | 2 +- packages/core/test/_.dart | 6 +++--- packages/core/test/core_config_test.dart | 2 +- packages/core/test/src/internal/core_build_tree_test.dart | 4 ++-- .../fwfh_just_audio/lib/src/audio_player/audio_player.dart | 4 ++-- packages/fwfh_svg/test/svg_factory_test.dart | 2 +- packages/fwfh_webview/lib/src/web_view/web_view.dart | 2 +- 11 files changed, 19 insertions(+), 16 deletions(-) diff --git a/packages/core/lib/src/core_html_widget.dart b/packages/core/lib/src/core_html_widget.dart index feca4376c..ca1206dd1 100644 --- a/packages/core/lib/src/core_html_widget.dart +++ b/packages/core/lib/src/core_html_widget.dart @@ -50,13 +50,13 @@ class HtmlWidget extends StatefulWidget { final OnLoadingBuilder? onLoadingBuilder; /// The callback when user taps an image. - final void Function(ImageMetadata)? onTapImage; + final void Function(ImageMetadata imageMetadata)? onTapImage; /// The callback when user taps a link. /// /// Returns `true` if the url has been handled, /// the default handler will be skipped. - final FutureOr Function(String)? onTapUrl; + final FutureOr Function(String url)? onTapUrl; /// The values that should trigger rebuild. /// diff --git a/packages/core/lib/src/internal/flattener.dart b/packages/core/lib/src/internal/flattener.dart index 5b26ac1da..e9fed4891 100644 --- a/packages/core/lib/src/internal/flattener.dart +++ b/packages/core/lib/src/internal/flattener.dart @@ -15,7 +15,8 @@ class Flattener implements Flattened { final WidgetFactory wf; final _widgets = []; - List? _childrenBuilder; + List? + _childrenBuilder; late InheritanceResolvers _firstInheritanceResolvers; late List<_String> _firstStrings; diff --git a/packages/core/lib/src/internal/margin_vertical.dart b/packages/core/lib/src/internal/margin_vertical.dart index 09b86a77a..36daf6e64 100644 --- a/packages/core/lib/src/internal/margin_vertical.dart +++ b/packages/core/lib/src/internal/margin_vertical.dart @@ -36,7 +36,9 @@ class HeightPlaceholder extends WidgetPlaceholder { } @override - HeightPlaceholder wrapWith(Widget? Function(BuildContext, Widget) builder) => + HeightPlaceholder wrapWith( + Widget? Function(BuildContext context, Widget child) builder, + ) => this; static Widget _build( diff --git a/packages/core/lib/src/internal/ops/tag_table.dart b/packages/core/lib/src/internal/ops/tag_table.dart index 814387bd9..508155b7c 100644 --- a/packages/core/lib/src/internal/ops/tag_table.dart +++ b/packages/core/lib/src/internal/ops/tag_table.dart @@ -466,7 +466,7 @@ class _TagTableData { final footer = _TagTableRowGroup(kCssDisplayTableFooterGroup); final header = _TagTableRowGroup(kCssDisplayTableHeaderGroup); - final builders = []; + final builders = []; final cells = >{}; int columns = 0; int rows = 0; diff --git a/packages/core/lib/src/widgets/html_details.dart b/packages/core/lib/src/widgets/html_details.dart index 4e66a9041..028430ab2 100644 --- a/packages/core/lib/src/widgets/html_details.dart +++ b/packages/core/lib/src/widgets/html_details.dart @@ -112,7 +112,7 @@ extension on BuildContext { class _HtmlDetailsInherited extends InheritedWidget { final bool isOpen; - final void Function(bool) setIsOpen; + final void Function(bool value) setIsOpen; const _HtmlDetailsInherited({ required super.child, diff --git a/packages/core/test/_.dart b/packages/core/test/_.dart index 2c74c513b..c02f5b685 100644 --- a/packages/core/test/_.dart +++ b/packages/core/test/_.dart @@ -27,7 +27,7 @@ Widget? buildCurrentState({GlobalKey? key}) { Future explain( WidgetTester tester, String? html, { - String? Function(Explainer, Widget)? explainer, + String? Function(Explainer explainer, Widget child)? explainer, double? height, Widget? hw, GlobalKey? key, @@ -82,7 +82,7 @@ Future explain( } Future explainWithoutPumping({ - String? Function(Explainer, Widget)? explainer, + String? Function(Explainer explainer, Widget child)? explainer, GlobalKey? key, bool useExplainer = true, }) async { @@ -216,7 +216,7 @@ Future tapText(WidgetTester tester, String data) async { class Explainer { final BuildContext context; - final String? Function(Explainer, Widget)? explainer; + final String? Function(Explainer explainer, Widget child)? explainer; final TextStyle _defaultStyle; Explainer(this.context, {this.explainer}) diff --git a/packages/core/test/core_config_test.dart b/packages/core/test/core_config_test.dart index 16b9a149e..fe2aa6550 100644 --- a/packages/core/test/core_config_test.dart +++ b/packages/core/test/core_config_test.dart @@ -679,7 +679,7 @@ class _OnErrorBuilderFactory extends WidgetFactory { class _OnTapUrlApp extends StatelessWidget { final String href; - final FutureOr Function(String)? onTapUrl; + final FutureOr Function(String url)? onTapUrl; final List? onTapCallbackResults; const _OnTapUrlApp({ diff --git a/packages/core/test/src/internal/core_build_tree_test.dart b/packages/core/test/src/internal/core_build_tree_test.dart index 087bdb330..5a59a1f4a 100644 --- a/packages/core/test/src/internal/core_build_tree_test.dart +++ b/packages/core/test/src/internal/core_build_tree_test.dart @@ -99,8 +99,8 @@ dom.NodeList _parseHtml(String html) => parser.HtmlParser(html, parseMeta: false).parseFragment().nodes; class _WidgetFactory extends WidgetFactory { - final void Function(BuildTree)? onParse; - final void Function(BuildTree)? onParseStyle; + final void Function(BuildTree value)? onParse; + final void Function(BuildTree value)? onParseStyle; _WidgetFactory({ this.onParse, diff --git a/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart b/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart index e537b6526..910802961 100644 --- a/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart +++ b/packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart @@ -216,7 +216,7 @@ class _PositionText extends StatelessWidget { class _PositionSlider extends StatelessWidget { final Stream durationStream; final Stream positionStream; - final void Function(Duration) seek; + final void Function(Duration duration) seek; final double size; const _PositionSlider({ @@ -257,7 +257,7 @@ class _PositionSlider extends StatelessWidget { } class _MuteButton extends StatelessWidget { - final Future Function(double) setVolume; + final Future Function(double value) setVolume; final double size; final Stream stream; diff --git a/packages/fwfh_svg/test/svg_factory_test.dart b/packages/fwfh_svg/test/svg_factory_test.dart index 6bec1df3e..91cfc971a 100644 --- a/packages/fwfh_svg/test/svg_factory_test.dart +++ b/packages/fwfh_svg/test/svg_factory_test.dart @@ -446,7 +446,7 @@ HttpClient _createMockSvgImageHttpClient() { ), ).thenAnswer((invocation) { final onData = - invocation.positionalArguments[0] as void Function(List); + invocation.positionalArguments[0] as void Function(List data); final onDone = invocation.namedArguments[const Symbol('onDone')] as Function?; return Stream.fromIterable(>[redTriangleBytes]) diff --git a/packages/fwfh_webview/lib/src/web_view/web_view.dart b/packages/fwfh_webview/lib/src/web_view/web_view.dart index 2e1cae5ce..2c545ef86 100644 --- a/packages/fwfh_webview/lib/src/web_view/web_view.dart +++ b/packages/fwfh_webview/lib/src/web_view/web_view.dart @@ -46,7 +46,7 @@ class WebView extends StatefulWidget { /// Returning `true` will stop web view from navigating. /// /// Flutter Web is not supported. - final bool Function(String)? interceptNavigationRequest; + final bool Function(String value)? interceptNavigationRequest; /// {@template web_view.js} /// Controls whether to enable JavaScript.