Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join common from a space #2076

Closed
6 of 7 tasks
elatif2020 opened this issue Sep 13, 2023 · 9 comments · Fixed by #2091
Closed
6 of 7 tasks

Join common from a space #2076

elatif2020 opened this issue Sep 13, 2023 · 9 comments · Fixed by #2091
Assignees
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Sep 13, 2023

Guests in a space (with autojoin both for the rootCommon and for space, otherwise show backpage):

  • Show (public parts of) front page

  • In the front page: “Join $RootCommonName” in the bottom of selected chat*

  • Add "Join via common page" button with a link to the root-common in the backpage.

  • ->Stay at (or jump to) that space front page (but now with writing option in chat)

  • BE: Follow only common Home and that space Home upon joining

  • In the backpage make the $parentCommonName a link to it.

  • For unauthenticated user ask to user first to login\signup and after it check membership again and do the relevant action.

** If the user is a member in the root common and not in the parent we should show a message instead of the join button:
"To join this space you should first join $ParentCommonName" (with a link)

@NoamQA
Copy link
Collaborator

NoamQA commented Sep 13, 2023

@elatif2020
what happens if a user get a link to the about page of a space?
there is no join button there
or a way to open the parent common or front page of the space
do we have a ticket for it?
maybe the name of the common should be a link?

Image

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 Again about redirecting to the back page if we are not a member of current space.
We should redirect user to the back page if:

  1. we are not a member of root common (not parent)
  2. and there is no autojoin either in root common, or in space

Otherwise, if we are either member of root common, or there is autojoin in both root space and space, then we show public content, correct?

@elatif2020
Copy link
Collaborator Author

@elatif2020 Again about redirecting to the back page if we are not a member of current space.
We should redirect user to the back page if:

  1. we are not a member of root common (not parent)
  2. and there is no autojoin either in root common, or in space

Otherwise, if we are either member of root common, or there is autojoin in both root space and space, then we show public content, correct?

yes sounds good

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 At the moment after log in user is redirected to the inbox page. Should we stay on the front or back page if the user logged in from them?

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Sep 19, 2023

@elatif2020 At the moment after log in user is redirected to the inbox page. Should we stay on the front or back page if the user logged in from them?

@andreymikhadyuk
should stay at the front page
or redirect to it if coming from the backpage

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 should we remove text Space 4 is a space in the Test from new spaces common. Only common members can join the space.?
image

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 do we need to display Join via common page not Join via $rootCommonName page on the back page?

@elatif2020
Copy link
Collaborator Author

@elatif2020 do we need to display Join via common page not Join via $rootCommonName page on the back page?

it should be with the relevant name as you wrote

@andreymikhadyuk andreymikhadyuk linked a pull request Sep 19, 2023 that will close this issue
4 tasks
andreymikhadyuk added a commit that referenced this issue Sep 26, 2023
@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 12, 2023

Maybe issue https://github.com/daostack/common-backend/issues/2172 is related here, not sure, need to check
Also created issue #2191 for the missing backpage button

@NoamQA NoamQA added the V [production] verified on production enviroment label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants