Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update space items counters without refresh #2190

Closed
elatif2020 opened this issue Oct 12, 2023 · 4 comments · Fixed by #2213
Closed

Update space items counters without refresh #2190

elatif2020 opened this issue Oct 12, 2023 · 4 comments · Fixed by #2213
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 12, 2023

Also the new streams line shouldn't be empty (so it can be 0 updated streams if there are no)

before refresh
Image

after refresh

Image

@andreymikhadyuk
Copy link
Collaborator

@budnik9 Also we should move const { projectUnreadStreamsCount, projectUnreadMessages } = useFeedItemCounters(item.id, commonId); from FeedItem to ProjectFeedItem, because it is needed only there.

@budnik9
Copy link
Contributor

budnik9 commented Oct 18, 2023

@elatif2020 Please share what common you used to reproduce this problem. I can't reproduce it in my test common.

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 18, 2023

@budnik9 I can't reproduce it now (tried on staging, here). Maybe it was already solved?

@budnik9
Copy link
Contributor

budnik9 commented Oct 18, 2023

@elatif2020 Works as expected for me, too. It could be a bug on the backend side. For example, I found a bug on the backend side. If you write, for example, two messages in a discussion and later delete one of them, the backend will return wrong counter values or nothing will be updated at all.
Will create a PR with a minor fix (displaying 0 streams updated if nothing has been updated). I haven't found other issues on the FE side.

@budnik9 budnik9 linked a pull request Oct 18, 2023 that will close this issue
4 tasks
pvm-code added a commit that referenced this issue Oct 20, 2023
…em-counters-issue

Update space items counters without refresh #2190
@NoamQA NoamQA added the V [production] verified on production enviroment label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants