Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make breadcrumb appear faster #2234

Closed
elatif2020 opened this issue Oct 24, 2023 · 3 comments · Fixed by #2243
Closed

make breadcrumb appear faster #2234

elatif2020 opened this issue Oct 24, 2023 · 3 comments · Fixed by #2243
Assignees
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 24, 2023

Don't need to load all the subcommons data, only the visible data.
In a space this data should already be available.

Load subcommons once a user opens the dropdown (first time), and while loading show the first (active) item + a loader

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 The ticket took lots of time and I created PR for it. Please play with it and check whether current implementation is ok or write down what's more you would want to change.

@elatif2020
Copy link
Collaborator Author

Hi,
thanks @andreymikhadyuk
It is much better now.
But there is an issue I have when being in a space and clicking back on the parent common, the space item stays in the breadcrumb. It might also be related to the issue in the db. I will check it further tomorrow.

@elatif2020
Copy link
Collaborator Author

Now without the issue in the db it is working great @andreymikhadyuk 🙏

pvm-code added a commit that referenced this issue Oct 25, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants