Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change system messages design #2238

Closed
4 tasks done
elatif2020 opened this issue Oct 24, 2023 · 3 comments · Fixed by #2242 or #2264
Closed
4 tasks done

change system messages design #2238

elatif2020 opened this issue Oct 24, 2023 · 3 comments · Fixed by #2242 or #2264
Assignees
@roienatan
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 24, 2023 •
edited by roienatan
Loading

  • Align the message to the center, and make the bubble fit the text size
  • See the design here for the colors and the font size
  • Remove the time (hour) indication for system messages
  • Text direction always LTR, also if the userName \ itemName is in Hebrew (RTL)
@elatif2020 elatif2020 changed the title change system messages aligmnet to be always to the left change system messages text direction to be always LTR Oct 24, 2023
@elatif2020 elatif2020 changed the title change system messages text direction to be always LTR change system messages design Oct 24, 2023
@roienatan roienatan linked a pull request Oct 24, 2023 that will close this issue
change system messages design #2238 #2242
Merged
3 tasks
@elatif2020
Copy link
Collaborator Author

@roienatan after rethinking about it, we want to change the text color to Gray 60 - 6B718E

@roienatan
Copy link
Collaborator

@roienatan after rethinking about it, we want to change the text color to Gray 60 - 6B718E

@elatif2020 done.

pvm-code added a commit that referenced this issue Oct 25, 2023
@pvm-code
Merge pull request #2242 from daostack/cw-2238-updated-system-message…
1b5b75d 
…-design

change system messages design #2238
@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 26, 2023 •
edited
Loading

@roienatan
here the text direction should be LTR
i.e. the mentioned name should appear to the left of the text (as if the whole text is in English)

Image

@elatif2020 elatif2020 reopened this Oct 26, 2023
@roienatan roienatan linked a pull request Oct 29, 2023 that will close this issue
change system messages design #2238 #2264
Merged
3 tasks
pvm-code added a commit that referenced this issue Oct 30, 2023
@pvm-code
Merge pull request #2264 from daostack/cw-2238-system-message-always-ltr
6042fa0 
change system messages design #2238
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Nov 1, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roienatan roienatan

Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
6 participants
@andreymikhadyuk @budnik9 @roienatan @pvm-code @elatif2020 @NoamQA