Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase allowed number of pinned items to 7 #2239

Closed
elatif2020 opened this issue Oct 24, 2023 · 2 comments · Fixed by #2275
Closed

Increase allowed number of pinned items to 7 #2239

elatif2020 opened this issue Oct 24, 2023 · 2 comments · Fixed by #2275
Assignees
@roienatan
Labels
Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 24, 2023 •
edited
Loading

Currently we restrict it to 3 and we want to allow 7 (or 5 if it's an issue).

Do we need make it in the FE or BE or both?
@elatif2020 elatif2020 transferred this issue from another repository Oct 24, 2023
@elatif2020 elatif2020 changed the title Increase allowed number of pinned items to 5 Increase allowed number of pinned items to 7 Oct 24, 2023
@roienatan
Copy link
Collaborator

roienatan commented Oct 30, 2023 •
edited
Loading

@elatif2020 change is required now only in the FE. Regardless, currently we show the Pin icon only when this condition applies: seenOnce && !unreadMessages. Why don't we show it always?

@roienatan roienatan linked a pull request Oct 30, 2023 that will close this issue
Increase allowed number of pinned items to 7 #2239 #2275
Merged
3 tasks
@elatif2020
Copy link
Collaborator Author

@elatif2020 change is required now only in the FE. Regardless, currently we show the Pin icon only when this condition applies: seenOnce && !unreadMessages. Why don't we show it always?

@roienatan
We hide it to avoid to many icons there (it's similar in Telegram)
BE changes were already made to allow it

andreymikhadyuk added a commit that referenced this issue Oct 31, 2023
@andreymikhadyuk
Merge pull request #2275 from daostack/cw-2239-allow-upto-7-pinned-items
1905140 
Increase allowed number of pinned items to 7 #2239
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Nov 2, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roienatan roienatan

Labels
Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase allowed number of pinned items to 7 #2239 daostack/common-web
3 participants
@roienatan @elatif2020 @NoamQA