Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display correct circle visibility for feedItems #2252

Closed
elatif2020 opened this issue Oct 26, 2023 · 0 comments · Fixed by #2278
Closed

Display correct circle visibility for feedItems #2252

elatif2020 opened this issue Oct 26, 2023 · 0 comments · Fixed by #2278
Assignees
@roienatan
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

We made a change in the BE to allow circle visibility by common
Image

While previously we had
Image

Probably FE should be trying both options (not sure whether we made a migration of old items)
@roienatan roienatan linked a pull request Oct 30, 2023 that will close this issue
Display correct circle visibility for feedItems #2252 #2278
Merged
3 tasks
andreymikhadyuk added a commit that referenced this issue Oct 31, 2023
@andreymikhadyuk
Merge pull request #2278 from daostack/cw-2252-correct-circle-visibil…
9560f66 
…ity-string

Display correct circle visibility for feedItems #2252
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Nov 1, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roienatan roienatan

Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display correct circle visibility for feedItems #2252 daostack/common-web
6 participants
@danielr18 @budnik9 @roienatan @pvm-code @elatif2020 @NoamQA