Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (personal) @ icon on unread “mentioned” stream #2254

Closed
elatif2020 opened this issue Oct 26, 2023 · 2 comments · Fixed by #2291 or #2323
Closed

Add (personal) @ icon on unread “mentioned” stream #2254

elatif2020 opened this issue Oct 26, 2023 · 2 comments · Fixed by #2291 or #2323
Assignees
@roienatan
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 26, 2023 •
edited
Loading

See design for adding "@" icon on the cards
Should be cleared up (optimistically) once the user open the chat

BE ticket is done https://github.com/daostack/common-backend/issues/2201
@elatif2020 elatif2020 removed the backend label Nov 2, 2023
@roienatan roienatan linked a pull request Nov 3, 2023 that will close this issue
Add (personal) @ icon on unread “mentioned” stream #2254 #2291
Merged
3 tasks
roienatan added a commit that referenced this issue Nov 6, 2023
@roienatan
Merge pull request #2291 from daostack/cw-2254-show-@-tag-if-mentioned
3495fc3 
Add (personal) @ icon on unread “mentioned” stream #2254
@elatif2020
Copy link
Collaborator Author

@roienatan
currently @ icon is displayed on all streams while loading the inbox\space feed, and disappear afterward
it should be the opposite, so don't display it until we get the data that it should be there

@elatif2020 elatif2020 reopened this Nov 17, 2023
@roienatan roienatan linked a pull request Nov 19, 2023 that will close this issue
Add (personal) @ icon on unread “mentioned” stream #2254 #2323
Merged
3 tasks
@roienatan
Copy link
Collaborator

@roienatan currently @ icon is displayed on all streams while loading the inbox\space feed, and disappear afterward it should be the opposite, so don't display it until we get the data that it should be there

@elatif2020 yes definitely, please verify in the review app here #2323

roienatan added a commit that referenced this issue Nov 20, 2023
@roienatan
Merge pull request #2323 from daostack/cw-2254-@-unread-mention
76f501f 
Add (personal) @ icon on unread “mentioned” stream #2254
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roienatan roienatan

Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
4 participants
@budnik9 @roienatan @elatif2020 @NoamQA