Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages all the way down in chat #2260

Closed
elatif2020 opened this issue Oct 26, 2023 · 12 comments · Fixed by #2290
Closed

Messages all the way down in chat #2260

elatif2020 opened this issue Oct 26, 2023 · 12 comments · Fixed by #2290
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 26, 2023

Right now message bubbles don’t go all the way down in the chat, we kept some space to avoid the action menu from being hidden. Now that the menu is opening upward if needed we can remove this space (similar to whatsapp or telegram)

@budnik9
Copy link
Contributor

budnik9 commented Oct 26, 2023

@elatif2020 What about the empty chat?

image

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 29, 2023

@elatif2020 What about the empty chat?

@budnik9
It's not exactly this ticket but it could be great to make the placeholder message centered both vertically and horizontally

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 30, 2023

@budnik9
I just noticed we have also this extra white space at the bottom (see the red arrow below)
Image
Can you also take care of removing it with this ticket?

@budnik9
Copy link
Contributor

budnik9 commented Oct 30, 2023

@elatif2020 Currently we have an issue with the chat styling in the v04 and chat within a modal window. With the requirements implemented, it doesn't look good

image

image

As I understand, this small extra space (in the your above comment) is a fix of this problem in the new layout chat. So we need to fix this problem first, and then apply the changes from this ticket (they have already been implemented by me)

@elatif2020
Copy link
Collaborator Author

@elatif2020 Currently we have an issue with the chat styling in the v04 and chat within a modal window. With the requirements implemented, it doesn't look good

image

image

As I understand, this small extra space (in the your above comment) is a fix of this problem in the new layout chat. So we need to fix this problem first, and then apply the changes from this ticket (they have already been implemented by me)

@budnik9
Not sure I understand. It seems by the images that the issue is with setting the scrolling limits to fit the visible area.

@budnik9
Copy link
Contributor

budnik9 commented Oct 30, 2023

@elatif2020 This scrolling limits is controlled by css styles. The chat container seems to be ignoring the height of the message input

@budnik9
Copy link
Contributor

budnik9 commented Nov 1, 2023

@elatif2020 Have you seen my comment above?

@elatif2020
Copy link
Collaborator Author

@budnik9 yes, but I'm not sure I got you. Are you blocked here or in progress of solving it?
If needed maybe @roienatan can help here

@budnik9
Copy link
Contributor

budnik9 commented Nov 1, 2023

@elatif2020 I wanted to say that firstly we have to fix the issue with chat within a modal and in the v04. After that we can merge implementation of requirements of this ticket.
I can fix the issue #2260 (comment) as part of this ticket. Or we can create a new ticket for this issue.

@elatif2020
Copy link
Collaborator Author

@elatif2020 I wanted to say that firstly we have to fix the issue with chat within a modal and in the v04. After that we can merge implementation of requirements of this ticket. I can fix the issue #2260 (comment) as part of this ticket. Or we can create a new ticket for this issue.

@budnik9
okay got you thanks
yes please fix it as part of this ticket

@budnik9 budnik9 linked a pull request Nov 3, 2023 that will close this issue
5 tasks
@elatif2020
Copy link
Collaborator Author

@budnik9
See the image below. Better that the menu wouldn't go on top of the input-box, should open upward in this case.

Image

@budnik9
Copy link
Contributor

budnik9 commented Nov 6, 2023

@budnik9 See the image below. Better that the menu wouldn't go on top of the input-box, should open upward in this case.

Image

Fixed!

andreymikhadyuk added a commit that referenced this issue Nov 7, 2023
…rovements

Messages all the way down in chat #2260
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants