Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support url parameter to show an inbox chat #2287

Closed
elatif2020 opened this issue Nov 2, 2023 · 7 comments · Fixed by #2305 or #2361
Closed

Support url parameter to show an inbox chat #2287

elatif2020 opened this issue Nov 2, 2023 · 7 comments · Fixed by #2305 or #2361

Comments

@elatif2020
Copy link
Collaborator

The format /inbox?item=$feedItemId
e.g. https://common.io/inbox?item=73922a25-cbe1-4643-86a7-e3453214dd8a
Comments
Should focus on that item in the inbox. In mobile it should open the relevant chat in the context of the inbox (such that back arrow bring to the inbox).

@elatif2020
Copy link
Collaborator Author

@budnik9
On mobile it's displaying the right content for a second and then redirect to ?chatItem query parameter reloads and shows an infinite loader. Should be fixed both in the current version and in v04.

On desktop it's good.

@budnik9
Copy link
Contributor

budnik9 commented Nov 22, 2023

@budnik9 On mobile it's displaying the right content for a second and then redirect to ?chatItem query parameter reloads and shows an infinite loader. Should be fixed both in the current version and in v04.

On desktop it's good.

@elatif2020 Is it still reproducible for you?
I don't have an infinite loader

@elatif2020
Copy link
Collaborator Author

I still have an issue here

@budnik9
Copy link
Contributor

budnik9 commented Nov 23, 2023

Could you please provide details how to reproduce it? Or maybe can you attach a video?

@budnik9
Copy link
Contributor

budnik9 commented Nov 24, 2023

@elatif2020 Have you seen my above comment?

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Nov 27, 2023

@budnik9
Here is from the desktop in responsive mode
I have similar behavior on my mobile device
This is the link I used here:
https://web-dev.common.io/inbox?item=388aa3ac-62cb-4032-bfb1-186308dd46c1

Untitled.video.-.Made.with.Clipchamp.mp4

@budnik9 budnik9 linked a pull request Nov 29, 2023 that will close this issue
3 tasks
@elatif2020
Copy link
Collaborator Author

looking good now 🙏

andreymikhadyuk added a commit that referenced this issue Nov 30, 2023
…-issue

Support url parameter to show an inbox chat #2287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants