Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use caching to load inbox and feed faster #2288

Closed
2 of 3 tasks
elatif2020 opened this issue Nov 2, 2023 · 9 comments · Fixed by #2301 or #2328
Closed
2 of 3 tasks

Use caching to load inbox and feed faster #2288

elatif2020 opened this issue Nov 2, 2023 · 9 comments · Fixed by #2301 or #2328
Assignees
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Nov 2, 2023

If there is data in the cache FE should first display the available data and then update it once updated information is received from firebase \ from the BE

  • For the Inbox
  • For the Feed
  • If possible maybe keep also a rendered version of last page(s) in memory to enable fast switching between pages

See discussion in Common here

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 @NoamQA Pushed changes for unfollowed inbox items removal.

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Nov 8, 2023

@andreymikhadyuk
@NoamQA fyi

  • unfollowed items remain in the Inbox also after switching to spaces and back (also after several seconds)
  • newly followed item doesn't appear in the inbox
  • Unfollow space - stars are brought back after a second
  • System crash after clicking unfollow space several times and doesn't load with console errors (inbox is loading but some spaces doesn't)

Image

  • new created discussion appearance in the inbox (either by me or by other user in a space I follow)

@andreymikhadyuk
Copy link
Collaborator

andreymikhadyuk commented Nov 9, 2023

@elatif2020 first and second points work fine for me. Please do the screen recording to understand what is exactly the issue.

@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk this is the crash

Uploading Common — Mozilla Firefox 2023-11-09 12-48-12.mp4…

@andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk this is the crash

Uploading Common — Mozilla Firefox 2023-11-09 12-48-12.mp4…

Video is not uploaded.

@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk this is the crash

Common.Mozilla.Firefox.2023-11-09.12-48-12.mp4

@andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk this is the crash

Common.Mozilla.Firefox.2023-11-09.12-48-12.mp4

I cannot reproduce it just be following/unfollowing spaces. Are there specific steps to reproduce the crash?

andreymikhadyuk added a commit that referenced this issue Nov 13, 2023
…hing

Use caching to load inbox and feed faster #2288
@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk

  1. Notice the issue Blinking space's letters avatar on loading #2318 which might be related to this change
  2. The navigation to the inbox now is very quick but to spaces it is slower. Do you know why is it? Could be good if we can also make spaces (especially the last visited one) load as fast as the inbox.

@andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk

  1. Notice the issue Blinking space's letters avatar on loading #2318 which might be related to this change
  2. The navigation to the inbox now is very quick but to spaces it is slower. Do you know why is it? Could be good if we can also make spaces (especially the last visited one) load as fast as the inbox.

If something from this still needs to be done, please create a separate ticket.

andreymikhadyuk added a commit that referenced this issue Nov 21, 2023
…ading

Use caching to load inbox and feed faster - Make feed loading faster #2288
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
6 participants