Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile add breadcrumb to expanded cards info #2295

Closed
elatif2020 opened this issue Nov 5, 2023 · 3 comments · Fixed by #2330
Closed

Mobile add breadcrumb to expanded cards info #2295

elatif2020 opened this issue Nov 5, 2023 · 3 comments · Fixed by #2330
Assignees

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Nov 5, 2023

See design here
Image

Logic for truncating long breadcrumb:
common > spaceN > ... > space1

  • If possible display the full breadcrumb
  • If not try displaying 3 or 4 items by removing items in the middle, starting with spaceN, space(N-1)... (showing ">...>" instead) and limiting each item to 10 characters (+3dots afterward)
  • Otherwise, if possible show only the first (common) and last (space1) items with >...> in the middle
  • Otherwise truncate the text of those items to fit, allowing each of them at least half of the available space (if one of them is shorter it could allow the other one to be a bit longer)

Anyway show >..> only once

Each item in the breadcrumb should be clickable with a link to the feed of the relevant space

@elatif2020 elatif2020 self-assigned this Nov 5, 2023
@elatif2020 elatif2020 assigned roienatan and unassigned elatif2020 Nov 7, 2023
@roienatan roienatan linked a pull request Nov 22, 2023 that will close this issue
3 tasks
@roienatan
Copy link
Collaborator

@elatif2020 as discussed, for now we support everything but showing 3 or 4 items.

@elatif2020
Copy link
Collaborator Author

@roienatan
currently I see only the name of the first item (the root common),
should show at least also the name of the last item (the space this item is in)

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Nov 30, 2023

now it's good 🙏
@andreymikhadyuk let's move forward with reviewing and merging this ticket

andreymikhadyuk added a commit that referenced this issue Nov 30, 2023
Mobile add breadcrumb to expanded cards info #2295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants