Notion integration FE

[elatif2020]

BE pr with info https://github.com/daostack/common-backend/pull/2220

1. Set up the integration

• Add section to add integration details on Space's creation see designs unchecked & collapsed, expanded,
• Display an error pop-up in case the integration failed design
• Add section to add integration details on Space's edit
• Disable editing the fields on edit if an integration is set design
• But allow removing the integration -> in this case display a confirmation pop-up once the user click Save - design here
• Disable creating\removing integration if it's in process by other user

2. Display Notion icon on spaces and streams which are synced

• In the inbox for synced streams on closed cards design
• In the space title if it is synced design
• For sub-space cards in the feed (if the subspace is synced) (similar to inbox cards)
• Add tooltips on the Notion icons which show the name of the synced database for spaces and for streams (the same)

3. Add Notion link in expanded item cards

• Notion ID : $id (clickable) design

5. Change behavior on creation of new streams (TBD)
6. Change behavior regarding deletion of streams (TBD)

[elatif2020]

@andreymikhadyuk @danielr18 it's still partial but might be useful to have your review already

[andreymikhadyuk]

@elatif2020 Looks good to me.

[elatif2020]

@budnik9 Notice updates in the ticket and designs with all the texts and info that were missing. LMK if anything else is missing.

[elatif2020]

@budnik9
Notice an additional update in the instructions text in the create\edit space pages. The updated text is here.
Also, there are some additional text changes in these pages, could be good if you can implement those as well (both in the edit and create pages):

• In the caption: Spaces are specific areas of collaboration which contain more focused subspaces and single-topic streams.
• Mission placeholder: What is the scope and purpose of collaboration in this space? How does it serve the purpose of its parent space or the entire common?
• "Notion’s Internal Integration Secret" with capitals

[budnik9]

@elatif2020 @danielr18
Do we have any Notion secret (token) and Database ID for testing ?

[elatif2020]

@elatif2020 @danielr18 Do we have any Notion secret (token) and Database ID for testing ?

@budnik9
Notion secret: secret_FLrvwMjXOaSfQdxgeCCBBgqn3P2FXStdVkQW4FXRerH
Database ID: babcef1650bf4e388fff9540952589a5

Database link https://www.notion.so/daostack/babcef1650bf4e388fff9540952589a5?v=e0b4a6e9bea84e92b539daf3b83c7b0b&pvs=4

[elatif2020]

@budnik9
We have additional update in the instructions, in the 4th point the updated text is (also updated in Figma):
Make sure to include in the Notion database you would like to bridge with this space the following properties: Title, Description (Text type), Common (URL type). Optionally you can include also the built-in Notion properties: Created time, Created by, and Notion ID (those properties exist and will be used anyhow).

[budnik9]

@danielr18
Is this change deployed to the dev env?

[budnik9]

@elatif2020
What do you mean by notion ID? Do you mean the notion database ID?

[elatif2020]

@elatif2020 What do you mean by notion ID? Do you mean the notion database ID?

@budnik9
we changed it, see in the design, should be the name of the database

[danielr18]

budnik9

Yes

[budnik9]

@danielr18
Can we extend the notion object with a database title and a link to discussion in the notion database?

[danielr18]

@budnik9 The database title can be found in the common.
For the link, it's notion.so/{pageIdWithoutDashes}

[elatif2020]

@budnik9 The database title can be found in the common. For the link, it's notion.so/{pageIdWithoutDashes}

@budnik9 Is it good enough for the FE to use the title from the common data? regarding links I tested and it's working like this.

[budnik9]

@budnik9 The database title can be found in the common. For the link, it's notion.so/{pageIdWithoutDashes}

@budnik9 Is it good enough for the FE to use the title from the common data? regarding links I tested and it's working like this.

I believe it's good enough

[budnik9]

@danielr18
How can I define that the notion integration is in the process of creating/removing?

[danielr18]

You can check the syncLog collection

[budnik9]

@danielr18
There is no "progress" status (or something similar).
Also it looks like this collection returns sync status of the notion database items (discussions/proposals) but not the notion database itself.

[elatif2020]

@budnik9 If everything else is ready maybe we can move forward and take care of this issue separately

[elatif2020]

Hi @budnik9
I tested it a bit, two items are missing:

• Add section to add integration details on Space's creation see designs [unchecked & collapsed]

• Display an error pop-up in case the integration failed

• Add section to add integration details on Space's edit

• Disable editing the fields on edit if an integration is set

• But allow removing the integration -> in this case display a confirmation pop-up once the user click Save - design

• Display Notion icon on spaces and streams which are synced

• In the inbox for synced streams on closed cards - missing in the Inbox

• In the space title if it is synced

• For sub-space cards in the feed (if the subspace is synced) (similar to inbox cards) - missing

• Add tooltips on the Notion icons which show the name of the synced database for spaces and for streams (the same)

• Add Notion link in expanded item cards Notion ID : $id (clickable)

Later:

• Disable creating\removing integration if it's in process by other user

[budnik9]

@elatif2020
Should a tooltip be displayed when hovering over the notion icon for synced inbox items?

[elatif2020]

@budnik9
yes

[elatif2020]

@budnik9
To clarify another thing, an example of a sub-space card for example:

Here we should also have the Notion icon

[budnik9]

@elatif2020 We need backend changes to show tooltip for synced inbox items.
@danielr18 Can we extend data of the inbox item with common notion data?

Or we can extend discussions collection with notion database name

[elatif2020]

@danielr18 See Kiryl's comment above
@budnik9 I created a new ticket for completing related tasks in Sprint 31, here #2347