Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space (project) card appearing in the Inbox #2345

Closed
elatif2020 opened this issue Nov 27, 2023 · 1 comment · Fixed by #2369
Closed

Space (project) card appearing in the Inbox #2345

elatif2020 opened this issue Nov 27, 2023 · 1 comment · Fixed by #2369
Assignees
@andreymikhadyuk
Labels
bug Something isn't working Priority - A

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Nov 27, 2023 •
edited
Loading

Somehow a space card appeared in my Inbox (DEV)
See in the image the card with yellow square is the card I should see, but I see additionally the card with the red square which I should see only in the parent space and not in the inbox.
I guess it's also related to caching...
Image
@elatif2020 elatif2020 added bug Something isn't working Priority - A labels Nov 27, 2023
@roienatan
Copy link
Collaborator

After investigating here are my insights. To reproduce:

  • Go to your inbox and refresh the app.
  • Go to My Spaces
  • Go back to Inbox. The Project cards should appear.

It's definitely cache related, and it happens when addNewInboxItems is excreted. Looks like the data that is sent to this function contains the unnecessary projects items. I still couldn't figure out where/how this extra data is injected.

@elatif2020 elatif2020 assigned elatif2020 and unassigned roienatan and pvm-code Nov 28, 2023
@andreymikhadyuk andreymikhadyuk linked a pull request Nov 30, 2023 that will close this issue
Space (project) card appearing in the Inbox #2345 #2369
Merged
3 tasks
andreymikhadyuk added a commit that referenced this issue Nov 30, 2023
@andreymikhadyuk
Merge pull request #2369 from daostack/bugfix/CW-2345-space-item-in-i…
2ba2be0 
…nbox

Space (project) card appearing in the Inbox #2345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreymikhadyuk andreymikhadyuk

Labels
bug Something isn't working Priority - A
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Space (project) card appearing in the Inbox #2345 daostack/common-web
4 participants
@andreymikhadyuk @roienatan @pvm-code @elatif2020