Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize breadcrumb loading #2356

Closed
elatif2020 opened this issue Nov 28, 2023 · 6 comments · Fixed by #2364 or #2371
Closed

Optimize breadcrumb loading #2356

elatif2020 opened this issue Nov 28, 2023 · 6 comments · Fixed by #2364 or #2371
Assignees

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Nov 28, 2023

Currently the breadcrumb is maybe slowest loading item, especially in the inbox.
We already made some fix to make it faster (by not loading all the items in the dropdown menu every time) and maybe it was reverted with the caching and could be brought back.
Also we should be able to optimize it using caching.

@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk
Two comments here:

  1. The first time after login, in inbox, when I switch to another item which is in the parent common of previous item, the breadcrumb doesn't update.
  2. Let's remove the breadcrumb loader with the boxes animation, so just don't show anything until we have the text data. Alternatively we can show it only after 3 sec delay.

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 Please specify 2 point concrete. If we do not need loader I will just remove it.

@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk
let's remove

@andreymikhadyuk andreymikhadyuk linked a pull request Nov 30, 2023 that will close this issue
4 tasks
@andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk let's remove

I created PR where I removed loader. You can check.

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 I could reproduce first point once, but cannot do it again to understand what's the issue. Can you reproduce it always and the steps are same as you mentioned in the comment?

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Nov 30, 2023

now I couldn't reproduce it with the same item, but could with other items (similar to what I described)

pvm-code added a commit that referenced this issue Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants