Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE add "Move stream" action #2409

Closed
elatif2020 opened this issue Dec 19, 2023 · 5 comments · Fixed by #2423
Closed

FE add "Move stream" action #2409

elatif2020 opened this issue Dec 19, 2023 · 5 comments · Fixed by #2423
Assignees
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Dec 19, 2023

The flow is similar to "Link stream"
We are adding the option in the action menu "Move to..." stream (Use the icon in the design here, notice that here we're moving stream not a space, but it is similar)
with the same popup (but different title)
and call the relevant BE endpoint. BE ticket: https://github.com/daostack/common-backend/issues/2066
See also the conditions for moving streams in there
Don't allow for streams which are linked

@andreymikhadyuk
Copy link
Collaborator

andreymikhadyuk commented Dec 25, 2023

  • allowed for users which has both the MOVE_FROM_HERE permission in the original space and the MOVE_TO_HERE permission in the target space (Admin in both)
  • don't allow for streams which are linked
  • item should have public visibility OR if it is in context of the same root-common and autoJoin is enabled (for both spaces, or one of them is the root) allow it also for items visible to the base circle (Member)
  • don't allow moving the Home stream

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 Should we also skip auto-join check here?

@andreymikhadyuk
Copy link
Collaborator

@elatif2020 Should this option be enabled for proposals as well?

@andreymikhadyuk andreymikhadyuk linked a pull request Dec 25, 2023 that will close this issue
5 tasks
@elatif2020
Copy link
Collaborator Author

@elatif2020 Should we also skip auto-join check here?

we said we'll skip it for now

@elatif2020
Copy link
Collaborator Author

@elatif2020 Should this option be enabled for proposals as well?

disable moving for proposals

andreymikhadyuk added a commit that referenced this issue Dec 26, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants