Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space deletion as an action #2411

Closed
elatif2020 opened this issue Dec 20, 2023 · 8 comments · Fixed by #2415
Closed

Space deletion as an action #2411

elatif2020 opened this issue Dec 20, 2023 · 8 comments · Fixed by #2415
Assignees
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

If the permission to delete space as an action are enabled for the user (DELETE_COMMON action)
open a confirmation pop up upon clicking "Delete space" from 3dots menu in the backpage, here:
Image
(notice this option is currently enabled only if the user has permission to create delete space proposal, should make sure to show it also if the user has DELETE_COMMON action permissions)
Confirmation popup design here
Image
And if the conditions for space's deletion aren't met (we should use the logic from the existing modal), display this version
See BE ticket with the details on the endpoint: https://github.com/daostack/common-backend/issues/2234

@roienatan
Copy link
Collaborator

Need to update the UI after deletion. See ticket here: #2429

@NoamQA
Copy link
Collaborator

NoamQA commented Jan 3, 2024

@elatif2020
it works fine
maybe we should add to the delete message that subspaces will also be deleted

@NoamQA NoamQA added the V [dev] verified on dev enviroment label Jan 3, 2024
@NoamQA
Copy link
Collaborator

NoamQA commented Jan 3, 2024

@roienatan @elatif2020
there are some spaces in dev and web stage
that when i try to delete i get the old proposal window
for example this in dev
and this in web stage

Image

@NoamQA NoamQA reopened this Jan 3, 2024
@roienatan
Copy link
Collaborator

@NoamQA this is normal. The delete action is different than the delete proposal and they have different popups. @elatif2020 please confirm.

@NoamQA
Copy link
Collaborator

NoamQA commented Jan 3, 2024

@roienatan @roienatan
no i meant that there are spaces that when i try to delete them it is not by single action
i get the old pop up of delete common proposal

@roienatan
Copy link
Collaborator

@roienatan @roienatan

no i meant that there are spaces that when i try to delete them it is not by single action

i get the old pop up of delete common proposal

@NoamQA yes because it depends on the settings of the specific government. Maybe you can share some pictures so I'll confirm if it's okay or not.

@elatif2020
Copy link
Collaborator Author

@NoamQA @roienatan @danielr18
Okay I see, probably we need to create a migration to add this Delete action permission to existing spaces (but not for root commons)

@elatif2020
Copy link
Collaborator Author

Here is a BE ticket for the migration. Closing the FE ticket.

@NoamQA NoamQA added the V [production] verified on production enviroment label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants