Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need proper versioning #165

Open
jellegerbrandy opened this issue Mar 28, 2019 · 1 comment
Open

we need proper versioning #165

jellegerbrandy opened this issue Mar 28, 2019 · 1 comment

Comments

@jellegerbrandy
Copy link
Contributor

At the moment, we change the version number in package.json, but otherwise we do not fix in any way what that release consists of (there is no package published on npmjs, and no git tag that marks it).

this means that it is not clear what (for example) version 0.0.6 consists of - it is the commit in which the version number changed? Or does it contain also the pataches that are deployed to https://rinkeby.subgraph.daostack.io/subgraphs/name/v6/graphql ?

So what we need is precise versinoing. Since we are not releasing to npmjs, we can uses tags tag/0.0.7. But we need to make sure (meaning: have a system in place that more or less garantees) that the tagged version then will be deployed on rinkeby (and later on main) on https://rinkeby.subgraph.daostack.io/subgraphs/name/vVERSION_NUMBER

@jellegerbrandy jellegerbrandy changed the title need subgraph versioning we need proper versioning Mar 28, 2019
@jellegerbrandy
Copy link
Contributor Author

A "release" for the subgraph:

  • package.json is et to new semver version
  • a git tag that fixes the point in time that the release was made
  • upload of corresponding docker images to docker hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant