Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configuration variable to define the dappnodesdk version in the gha workflows #357

Open
pablomendezroyo opened this issue May 24, 2023 · 0 comments

Comments

@pablomendezroyo
Copy link
Contributor

Context
The current way of the gha workflows in the DAppNodePackages use by default the latest dappnodesdk version via the command npx @dappnode/dappnodesdk. This approach entails issues whenever a certain version is not stable and it may break the CI/CD in those packages using this tool.

Approach

  1. Create an organization configurable variable and use it in the workflows as an env, i.e:
    run: npx @dappnode/dappnodesdk@$DAPPNODE_SDK_VERSION
    env:
        ORGANIZATION_VAR: ${{ vars.ORGANIZATION_VAR }}
  1. Modify all the gha workflows to use this env in the dappnodesdk commands. Consider using a script for that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant