Added TryGetReminder method to actors
#1470
Open
+265
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reminder request failed or not. This updates it to return null if the reminder isn't present. Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…ActorTimerManager Signed-off-by: Whit Waldo <[email protected]>
… for constants Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…ut` parameters in async methods are not supported per https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/async#return-types Signed-off-by: Whit Waldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added method to try getting a named reminder from the actor. Especially as the
Dapr.Actorspackage doesn't support nullability annotations, it can be confusing to understand what a null value means (especially if it never returns null, which #1468 seeks to fix).As
outparameters aren't supported in async operations per this document, this instead implements an async method that returns aConditionalValue<TValue>.If the return type is not available,
HasValuewill be false and theValueproperty will be null. If the return type is available,HasValuewill be true and theValueproperty will be populated with theIActorRemindervalue.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1465
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: