Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include libmagic code? #5

Open
rstub opened this issue Aug 17, 2018 · 0 comments
Open

Include libmagic code? #5

rstub opened this issue Aug 17, 2018 · 0 comments
Assignees
@rstub

Comments

@rstub
Copy link
Member

rstub commented Aug 17, 2018

Currently the CI builds on Mac OS are failing, most likely because of different libmagic versions. Possible solution:

  • Include the libmagic source in the package since it is reasonably small and needed for Windows support anyway
  • During configure configure and build libmagic if no usable installation is found
  • On Windows always build the included sources, which have to be pre-configured, since Rtools are not sufficient to run configure

Open questions:

  • What should be the default if a usable libmagic installation is found?
@rstub rstub self-assigned this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstub rstub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rstub