Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop down can't be seen when filtering only 1 column #24

Open
FrankSchiro opened this issue Jan 5, 2021 · 0 comments
Open

Drop down can't be seen when filtering only 1 column #24

FrankSchiro opened this issue Jan 5, 2021 · 0 comments

Comments

@FrankSchiro
Copy link

FrankSchiro commented Jan 5, 2021

I have an issue where I can't see the dropdown menu if there is only 1 row because the table is too small.
This issue is fixed if I add css tags$style(".handsontable {overflow: visible !important; }"), however, this breaks the filter alignment.

To fix this, I had to set a minimum height to the table. In dq_render_handsontable, when the function is sending arguments to rhandsontable, I added these lines:

if(!is.null(app_input[[ns("pageSize")]])){    
            params[[1L]]$height = min(
                c(
                    50 * as.integer(app_input[[ns("pageSize")]]),
                    100 + 50 * nrow(dqv$full)
                )
            )
        }

This fixed the issue by setting a minimum height to the table. It would be easy to alter this to have a user defined height as one number in the min argument, or if the user defines minimum height just skip this code block.

I also tried setting min-height in the css of my ui, but that broke the dropdown option menu for some reason. Hope this helps someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant