Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arithmtic on params #224

Open
mahyarsamani opened this issue Jun 4, 2021 · 1 comment
Open

Arithmtic on params #224

mahyarsamani opened this issue Jun 4, 2021 · 1 comment

Comments

@mahyarsamani
Copy link
Contributor

I did a little check on how params are defined, I'm not sure if it is possible to do arithmetic operations on params, it would be nice if I could do this:

self._mem_size = '2GB'
self._cache_size = self._mem_size / 256

I think there are some use cases to this, for example in my gups test I need to break down some part of memory to smaller chunks, it will be nice if I could do it without converting _mem_size to int and converting _cache_size back to str.
@mahyarsamani
Copy link
Contributor Author

Also it would be nice to be able to do Addr = Addr + MemorySize or MemorySize = Addr - Addr.

kaustav-goswami pushed a commit that referenced this issue Oct 31, 2023
@abmerop
dev-amdgpu: Tell OS about PCIe atomic support (#224)
fcbed2b 
configs,dev-amdgpu: Add PCI express capability info

The ROCm stack requires PCI express atomics. Currently the first PCI
CapabilityPtr does not point to anything, which signals to the OS
(Linux) that this is an early generation PCI device. As PCI express
atomics were introduced later, the CapabilityPtr needs to point to at
least a PCI express capability structure. This capability is defined as
0x10 in Linux. We additionally set the PCI atomic based bits and
implement device specific PCI configuration space reads and writes to
the amdgpu device.

The second commit, output of simulation when loading the amdgpu
driver no longer outputs "PCIE atomics not supported". Further, an
application which uses PCIe atomics (PyTorch with a reduce_sum kernel)
now makes further progress.

First commit is a minor typo fix changing PCI capability struct to
union.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mahyarsamani