Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: Difference for embedded lens-correction for OM-System Mark II between DNG and ORF #712

Closed
astmuc opened this issue Apr 19, 2024 · 3 comments

Comments

@astmuc
Copy link

astmuc commented Apr 19, 2024

I can see the automatic lens correction using embedded info if the input is DNG. But i see no lens correction for the native ORF format.

Is this an effect of #686, or is it maybe simply an unsupported feature ?

@kmilos
Copy link
Collaborator

kmilos commented Apr 19, 2024

Lens correction is out of scope for the RawSpeed library.

Please seek support at https://discuss.pixls.us/c/software/darktable/19 or https://github.com/darktable-org/darktable/issues

@kmilos kmilos closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@kmilos
Copy link
Collaborator

kmilos commented Apr 19, 2024

Is this an effect of...

It is not.

@LebedevRI
Copy link
Member

None of the lens correction opcodes are supported by rawspeed:

switch (code) {
case 1U:
return make_pair("WarpRectilinear", nullptr);
case 2U:
return make_pair("WarpFisheye", nullptr);
case 3U:
return make_pair("FixVignetteRadial", nullptr);

case 9U:
return make_pair("GainMap", nullptr);

so @kmilos is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants