Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential for Collaboration (json-logic-engine) + publish benchmark script #1

Open
TotalTechGeek opened this issue Oct 16, 2021 · 1 comment

Comments

@TotalTechGeek
Copy link

Hey! Nice work on the JIT Engine!

I've a similar project json-logic-engine with some similar capability. I wanted to reach out & ask if you would be interested in collaborating on the compilation mechanism.

Could you also publish the benchmark script?

@darky
Copy link
Owner

darky commented Oct 17, 2021

Hello! Thanks!

If I found json-logic-engine before, maybe json-logic-js-jit would not appear :)

json-logic-js-jit have simple tiny core under the hood.

Compilation mechanism not much difficult, you can discover it here:
https://github.com/darky/json-logic-js-jit/blob/master/index.js

Also you can debug it, via fn.bytecode property. I use it in tests:
https://github.com/darky/json-logic-js-jit/blob/master/test.js

json-logic-js-jit is tiny and small by design. All desired stuff can be implemented via addOperation like json-logic-js-jit-tools - https://github.com/darky/json-logic-js-jit-tools

Could you also publish the benchmark script?

Sorry, I threw it out. I make some simple benchmark suite with basic operators and run it. Results here:
jwadhams/json-logic-js#107
Feel free to write own benchmarks and play with it.

If you found some interesting in json-logic-js-jit compilation mechanism, feel free to use it in json-logic-engine

My fluent comparison of json-logic-js-jit <-> json-logic-engine:
json-logic-engine has much more features and maybe aim to be full replacement to json-logic-js. json-logic-js-jit very tiny and small. It's by design to have "smart enough" core. All desired features anyone can implement via addOperation. Compatibility with json-logic-js is not goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants